core: Handle unterminated escape character when parsing partial JSON #29065
+3
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, when parsing a partial JSON, if a string ends with the escape character, the whole key/value is removed. For example:
My expectation (and with this fix) would be for
parse_partial_json()
to return:Notes:
\\
langchain/libs/core/langchain_core/output_parsers/transform.py
Line 111 in 187131c
since what happens is that, for example, if the received sequence of chunks are:
{"foo": "b
,ar\\
:Then, the result of calling
self.parse_result()
is:and the second time: