-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make-tier-comparison-header-sticky #6151
base: master
Are you sure you want to change the base?
make-tier-comparison-header-sticky #6151
Conversation
Signed-off-by: eyeaadil <[email protected]>
🚀 Preview for commit 09c907a at: https://677805329d3a5b036e174e6e--layer5.netlify.app |
Is this PR a duplicate of #6138? |
This PR looks pretty neat, but there is an extra space at the end of the table. This space grows larger as the window size decreases, which might misleadingly suggest that something hasn't rendered correctly or is still loading. A better use of this space could be to place call-to-action buttons there as well. Positioning the buttons in this spot would make it more convenient for users to access the free trial option without needing to scroll back to the top. |
@Ajay-singh1 I like the idea of having the header stick to the top, as shown in the video. However, don’t you think the table's content, including the expanded sections, might be too extensive? This could force users to scroll through everything, even if they’re not interested. |
@Venkata-Sai-Vishwanath-robo Yeah! I agree with you. |
Description
This PR fixes #6122
Notes for Reviewers
Preview for commit:https://677805329d3a5b036e174e6e--layer5.netlify.app/
After changes
Signed commits