Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ensure modal appears above iframe by adjusting z-index #6152

Merged
merged 2 commits into from
Jan 5, 2025

Conversation

FaheemOnHub
Copy link
Contributor

Description

This PR fixes #6150 issue where the modal was being obscured by the iframe. Adjusted the z-index in the navigation styles to resolve the problem.

Signed-off-by: Faheem Mushtaq [email protected]

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@l5io
Copy link
Contributor

l5io commented Jan 4, 2025

🚀 Preview for commit 626408f at: https://677901b7ba784ec5630df2f3--layer5.netlify.app

@FaheemOnHub FaheemOnHub force-pushed the bug/faheemonhub/6150 branch from 626408f to 1b9d30e Compare January 4, 2025 10:44
@l5io
Copy link
Contributor

l5io commented Jan 4, 2025

🚀 Preview for commit 1b9d30e at: https://677913b6b333f8cc383ea16d--layer5.netlify.app

Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FaheemOnHub thanks for identifying and working on this issue.

src/sections/General/Navigation/index.js Outdated Show resolved Hide resolved
@FaheemOnHub FaheemOnHub force-pushed the bug/faheemonhub/6150 branch from 1b9d30e to 5814eb4 Compare January 4, 2025 20:24
@l5io
Copy link
Contributor

l5io commented Jan 4, 2025

🚀 Preview for commit 5814eb4 at: https://67799bcc4f3ddf70ec822837--layer5.netlify.app

@l5io
Copy link
Contributor

l5io commented Jan 5, 2025

🚀 Preview for commit 44c437e at: https://677a027c96970bd9a77bde93--layer5.netlify.app

Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks, @FaheemOnHub

@leecalcote leecalcote merged commit 6e2e6c2 into layer5io:master Jan 5, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Profile Modal Hidden Behind iframe on Layer5.io Homepage
4 participants