Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Algebra/Algebra/Defs): add an algebraMap field to Algebra instead of extending RingHom #20518

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

edegeltje
Copy link
Collaborator

as proposed on zulip


Open in Gitpod

@edegeltje edegeltje added WIP Work in progress t-algebra Algebra (groups, rings, fields, etc) labels Jan 6, 2025
Copy link

github-actions bot commented Jan 6, 2025

PR summary 6fb5948c83

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

-+-+ algebra'
-+-+-+ algebra

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@edegeltje edegeltje removed the WIP Work in progress label Jan 6, 2025
@kbuzzard
Copy link
Member

kbuzzard commented Jan 6, 2025

!bench

@leanprover-bot
Copy link
Collaborator

Here are the benchmark results for commit 2890b28.
The entire run failed.
Found no significant differences.

@kbuzzard
Copy link
Member

kbuzzard commented Jan 7, 2025

!bench

@leanprover-bot
Copy link
Collaborator

Here are the benchmark results for commit e85e968.
The entire run failed.
Found no significant differences.

@kbuzzard
Copy link
Member

kbuzzard commented Jan 7, 2025

!bench

@leanprover-bot
Copy link
Collaborator

Here are the benchmark results for commit 6fb5948.
The entire run failed.
Found no significant differences.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-algebra Algebra (groups, rings, fields, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants