Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(Ringtheory/DedekindDomain/AdicValuation); add mem_integers_of_valuation_le_one #20523

Closed
wants to merge 6 commits into from

Conversation

kbuzzard
Copy link
Member

@kbuzzard kbuzzard commented Jan 6, 2025

A Lean 4 port of Junyan Xu's code here.


Open in Gitpod

@github-actions github-actions bot added the t-algebra Algebra (groups, rings, fields, etc) label Jan 6, 2025
Copy link

github-actions bot commented Jan 6, 2025

PR summary 652b2e848d

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ mem_integers_of_valuation_le_one

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Copy link
Collaborator

@Ruben-VandeVelde Ruben-VandeVelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nitpicks

Mathlib/RingTheory/DedekindDomain/AdicValuation.lean Outdated Show resolved Hide resolved
Mathlib/RingTheory/DedekindDomain/AdicValuation.lean Outdated Show resolved Hide resolved
Mathlib/RingTheory/DedekindDomain/AdicValuation.lean Outdated Show resolved Hide resolved
Mathlib/RingTheory/DedekindDomain/AdicValuation.lean Outdated Show resolved Hide resolved
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jan 8, 2025

✌️ kbuzzard can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@kbuzzard
Copy link
Member Author

kbuzzard commented Jan 8, 2025

Thanks!

bors r+

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jan 8, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Ringtheory/DedekindDomain/AdicValuation); add mem_integers_of_valuation_le_one [Merged by Bors] - feat(Ringtheory/DedekindDomain/AdicValuation); add mem_integers_of_valuation_le_one Jan 8, 2025
@mathlib-bors mathlib-bors bot closed this Jan 8, 2025
@mathlib-bors mathlib-bors bot deleted the kbuzzard-mem_integers_of_valuation_le_one branch January 8, 2025 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants