Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: test the cache as if in a downstream project #20532

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

kim-em
Copy link
Contributor

@kim-em kim-em commented Jan 7, 2025

Rather than just testing lake exe cache get && lake build --no-build, we run this test from a mini downstream project.

Sadly, we expect this to currently be failing on v4.16.0-rc1. I've tested that it works correctly on v4.15.0.

Having this test in place would have alerted us to the problems in v4.16.0-rc1 ahead of time.

@github-actions github-actions bot added the CI Modifies the continuous integration / deployment setup label Jan 7, 2025
Copy link

github-actions bot commented Jan 7, 2025

PR summary ab786c217f

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Modifies the continuous integration / deployment setup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant