Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(NumberTheory/NumberField/Basic): ringOfIntegersEquiv API #20544

Closed
wants to merge 2 commits into from

Conversation

kbuzzard
Copy link
Member

@kbuzzard kbuzzard commented Jan 7, 2025

Andrew Yang's proof that the obvious triangle to commutes.


Open in Gitpod

Copy link

github-actions bot commented Jan 7, 2025

PR summary df4ca25bc0

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ coe_ringOfIntegersEquiv

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-number-theory Number theory (also use t-algebra or t-analysis to specialize) label Jan 7, 2025
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

Mathlib/NumberTheory/NumberField/Basic.lean Show resolved Hide resolved
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jan 8, 2025

✌️ kbuzzard can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@kbuzzard
Copy link
Member Author

kbuzzard commented Jan 8, 2025

bors r+

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the ready-to-merge This PR has been sent to bors. label Jan 8, 2025
mathlib-bors bot pushed a commit that referenced this pull request Jan 8, 2025
Andrew Yang's proof that the obvious triangle to `ℚ` commutes.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jan 8, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(NumberTheory/NumberField/Basic): ringOfIntegersEquiv API [Merged by Bors] - feat(NumberTheory/NumberField/Basic): ringOfIntegersEquiv API Jan 8, 2025
@mathlib-bors mathlib-bors bot closed this Jan 8, 2025
@mathlib-bors mathlib-bors bot deleted the kbuzzard-coe_ringOfIntegersEquiv branch January 8, 2025 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated ready-to-merge This PR has been sent to bors. t-number-theory Number theory (also use t-algebra or t-analysis to specialize)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants