Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use ofNat more #20546

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

chore: use ofNat more #20546

wants to merge 2 commits into from

Conversation

grunweg
Copy link
Collaborator

@grunweg grunweg commented Jan 7, 2025

When a theorem statement contains both ofNat and OfNat.ofNat, replace the latter by the former: as eric-wieser says, these are mostly theorems that work forwards, but not backwards, with simp.

Very much not exhaustive, there are perhaps 160 instances in mathlib remaining.


Open in Gitpod

When a theorem statement contains both ofNat and OfNat.ofNat, replace the
latter by the former: as eric-wieser says, these are mostly theorems that
work forwards, but not backwards, with simp.
@grunweg
Copy link
Collaborator Author

grunweg commented Jan 7, 2025

@eric-wieser Does this match what you were thinking of?

Copy link

github-actions bot commented Jan 7, 2025

PR summary 47a30a39e3

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Mathlib/Algebra/AddConstMap/Basic.lean Outdated Show resolved Hide resolved
Mathlib/Algebra/AddConstMap/Basic.lean Outdated Show resolved Hide resolved
Mathlib/Algebra/AddConstMap/Basic.lean Outdated Show resolved Hide resolved
Mathlib/Algebra/AddConstMap/Basic.lean Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants