Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(ModelTheory/Algebra/Ring/Definability): re-squeeze a slow simp #20549

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

grunweg
Copy link
Collaborator

@grunweg grunweg commented Jan 7, 2025


Second version of #20120, but against mathlib master now.


The previous version didn't build, perhaps this is fine now.


Open in Gitpod

Second version of #20120, but against mathlib master now.

------

The previous version didn't build, perhaps this is fine now.
@grunweg grunweg added the easy < 20s of review time. See the lifecycle page for guidelines. label Jan 7, 2025
@grunweg grunweg requested a review from kim-em January 7, 2025 13:02
Copy link

github-actions bot commented Jan 7, 2025

PR summary 4ace4722e0

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-logic Logic (model theory, etc) label Jan 7, 2025
@Ruben-VandeVelde
Copy link
Collaborator

Please add a comment in the source that this is for perf reasons

!bench

@grunweg
Copy link
Collaborator Author

grunweg commented Jan 8, 2025

!bench

@leanprover-bot
Copy link
Collaborator

Here are the benchmark results for commit 4ace472.
There were no significant changes against commit 01b6f1b.

Copy link

github-actions bot commented Jan 8, 2025

No benchmark entry differed by at least +1.0⬝10⁹ instructions.
CI run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy < 20s of review time. See the lifecycle page for guidelines. t-logic Logic (model theory, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants