-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(ModelTheory/Algebra/Ring/Definability): re-squeeze a slow simp #20549
base: master
Are you sure you want to change the base?
Conversation
Second version of #20120, but against mathlib master now. ------ The previous version didn't build, perhaps this is fine now.
PR summary 4ace4722e0Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit> The doc-module for No changes to technical debt.You can run this locally as
|
Please add a comment in the source that this is for perf reasons !bench |
!bench |
Here are the benchmark results for commit 4ace472. |
No benchmark entry differed by at least +1.0⬝10⁹ instructions. |
Second version of #20120, but against mathlib master now.
The previous version didn't build, perhaps this is fine now.