Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Algebra/Group/Even): Clean up file, add Aesop automation #20558

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

artie2000
Copy link
Collaborator

@artie2000 artie2000 commented Jan 7, 2025

  • Rename some theorems for consistency and to remove some primed variants
  • Make API for IsSquare / Even consistent between the "official" definition and equivalent ones
  • Add and correct simp and aesop attributes to enable sensible automation
  • Add test examples for concluding IsSquare / Even by aesop

Moves:
Even.nsmul' -> Even.even_nsmul
Even.zsmul' -> Even.even_zsmul
isSquare_zero -> IsSquare.zero

Deletions:
isSquare_of_exists_sq (prefer IsSquare.sq)


Open in Gitpod

Copy link

github-actions bot commented Jan 7, 2025

PR summary 9d5d902e9c

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ Even.nsmul'
+ Even.zsmul'
+ IsSquare.zero
+ _
+ exists_apply_eq_and_isSquare
+ isSquare_iff_exists_mul_self
- even_add_self
- isSquare_of_exists_sq

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-algebra Algebra (groups, rings, fields, etc) label Jan 7, 2025
@artie2000 artie2000 requested a review from YaelDillies January 7, 2025 21:33
@artie2000 artie2000 marked this pull request as ready for review January 7, 2025 23:08

end Monoid

@[to_additive]
@[to_additive (attr := aesop unsafe 90% apply)]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you write a library note explaining the priority you choose here?

Copy link
Collaborator Author

@artie2000 artie2000 Jan 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll do this in general in #20477 and then review the priorities in this PR.

@artie2000 artie2000 marked this pull request as draft January 8, 2025 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-algebra Algebra (groups, rings, fields, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants