-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Algebra/Group/Even): Clean up file, add Aesop automation #20558
base: master
Are you sure you want to change the base?
Conversation
PR summary 9d5d902e9cImport changes for modified filesNo significant changes to the import graph Import changes for all files
|
|
||
end Monoid | ||
|
||
@[to_additive] | ||
@[to_additive (attr := aesop unsafe 90% apply)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you write a library note explaining the priority you choose here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll do this in general in #20477 and then review the priorities in this PR.
IsSquare
/Even
consistent between the "official" definition and equivalent onessimp
andaesop
attributes to enable sensible automationIsSquare
/Even
byaesop
Moves:
Even.nsmul'
->Even.even_nsmul
Even.zsmul'
->Even.even_zsmul
isSquare_zero
->IsSquare.zero
Deletions:
isSquare_of_exists_sq
(preferIsSquare.sq
)