[Merged by Bors] - feat: make spanning condition in RootSystem symmetric for roots and coroots.
#20564
+34
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
large-import
PR summary 21586cb511Import changes exceeding 2%
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.LinearAlgebra.RootSystem.Basic | 1389 | 1437 | +48 (+3.46%) |
| Mathlib.Algebra.Lie.Weights.RootSystem | 1561 | 1585 | +24 (+1.54%) |
Import changes for all files
| Files | Import difference |
|---|---|
Mathlib.Algebra.Lie.Weights.RootSystem |
24 |
Mathlib.LinearAlgebra.RootSystem.Basic |
48 |
Declarations diff
+ rootSpan_eq_top_iff
You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for script/declarations_diff.sh contains some details about this script.
No changes to technical debt.
You can run this locally as
./scripts/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
|
The "large import" change is not really avoidable: we need these extra dependencies in |
|
Thanks 🎉 If CI passes, please remove the label bors d+ |
|
✌️ ocfnash can now approve this pull request. To approve and merge a pull request, simply reply with |
|
bors merge |
leanprover-community-mathlib4-bot
added
the
ready-to-merge
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jan 9, 2025
… coroots. (#20564) The key change here is the additional axiom which I have added to root systems demanding `span R (range coroot) = ⊤`. This means that certain root pairings no longer qualify as root systems. We're in uncharted territory here (the informal literature only considers more specialised situations and so avoids this issue) but I claim the most useful definition will be one with a perfect symmetry between roots and coroots.
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
RootSystem symmetric for roots and coroots.RootSystem symmetric for roots and coroots.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The key change here is the additional axiom which I have added to root systems demanding
span R (range coroot) = ⊤.This means that certain root pairings no longer qualify as root systems. We're in uncharted territory here (the informal literature only considers more specialised situations and so avoids this issue) but I claim the most useful definition will be one with a perfect symmetry between roots and coroots.