Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Algebra/CharP/Defs): do not import Field #20566

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

YaelDillies
Copy link
Collaborator


Open in Gitpod

@github-actions github-actions bot added the t-algebra Algebra (groups, rings, fields, etc) label Jan 8, 2025
Copy link

github-actions bot commented Jan 8, 2025

PR summary cb868581fb

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.Algebra.CharP.Defs 420 398 -22 (-5.24%)
Mathlib.Algebra.CharP.Invertible 421 405 -16 (-3.80%)
Import changes for all files
Files Import difference
Mathlib.Algebra.CharP.Basic Mathlib.Algebra.CharP.Defs -22
Mathlib.Data.Matrix.CharP Mathlib.Algebra.CharP.Pi -21
Mathlib.Algebra.CharP.Invertible -16
3 files Mathlib.Combinatorics.Additive.AP.Three.Defs Mathlib.Combinatorics.Additive.FreimanHom Mathlib.Combinatorics.Additive.Corner.Defs
-10

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


Decrease in tech debt: (relative, absolute) = (1.00, 0.00)
Current number Change Type
4817 -1 porting notes

Current commit cb868581fb
Reference commit af8eed890c

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-algebra Algebra (groups, rings, fields, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant