Remove implicit png feature, only have png-format
#139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The optional `png` dependency creates an implicit `png` feature which shows up when you do a `cargo add tiny-skia` but that won't do anything when enabled. The right feature to enable is `png-format` so we only need to have that one.
xStrom
approved these changes
Dec 7, 2024
|
Designing this from scratch, I'd be inclined to name the feature |
|
Same and I would rather keep existing people working than a change they don’t care about. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The optional
pngdependency creates an implicitpngfeature which shows up when you do acargo add tiny-skiabut that won't do anything when enabled. The right feature to enable ispng-formatso we only need to have that one.