Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scale_by/scale_to functions to Size #146

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

jermy
Copy link
Contributor

@jermy jermy commented Dec 27, 2024

These match the implementations for for IntSize, making it simpler to implement floating point support in the resvg main binary.

This is part of a fix for resvg #810.

These match the implementations for for IntSize, making it simpler to
implement floating point support in the resvg main binary.
@jermy
Copy link
Contributor Author

jermy commented Dec 27, 2024

The corresponding resvg change is resvg #875

Copy link
Member

@DJMcNab DJMcNab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable. Thanks

@DJMcNab DJMcNab merged commit 34e7783 into linebender:main Jan 6, 2025
4 checks passed
@jermy jermy deleted the add_size_scale_functions branch January 6, 2025 11:37
@jermy
Copy link
Contributor Author

jermy commented Jan 6, 2025

@DJMcNab Thank you. Would it be reasonable to do a release of this at some point? (*) I can do a PR for a version bump, but have no idea what process is involved it getting it onto crates, and I suspect it might warrant going to 0.12.0 since it's been a while since the last release and there are quite a number of things that need adding to the changelog.

(* A caveat would be whether my other mipmap PR #145 would want to be included as well)

@DJMcNab
Copy link
Member

DJMcNab commented Jan 6, 2025

The place to ask this is probably on Zulip (i.e. creating a new thread in the resvg channel). Ultimately, tiny-skia doesn't really have a champion at the moment.

@waywardmonkeys
Copy link
Collaborator

I'm planning to get to a release of this once we get some other stuff released, hopefully this month. It would be good to get this crate a bit more aligned with Linebender stuff, but perhaps that won't happen for the first release under our banner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants