[MemoryBanking] Support multi-dimension memory banking #8033
+144
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgyurgyik
approved these changes
Jan 6, 2025
| memoryToBanks[memrefVal] = createBanks(memrefVal, bankingFactor); | ||
| for (auto memrefVal : memrefsInPar) { | ||
| if (!memoryToBanks.contains(memrefVal)) | ||
| memoryToBanks[memrefVal] = |
There was a problem hiding this comment.
I think 'try_emplace' is a better fit here, if this container supports it. This avoids the double lookup.
There was a problem hiding this comment.
Agree, I tried it out but the problem with it is that arguments will be evaluated so do something like try_emplace(memrefVal, createBanks(...)) will invoke createBanks function, which changes the block arguments in-place:
circt/lib/Transforms/MemoryBanking.cpp
Line 100 in 8fa4aad
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch supports multi-dimensional memory banking in the memory banking pass.