Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

๐Ÿ› fix: fix remark gfm regex breaks in Safari versions < 16.4 #5357

Merged
merged 2 commits into from
Jan 9, 2025
Merged

๐Ÿ› fix: fix remark gfm regex breaks in Safari versions < 16.4 #5357

merged 2 commits into from
Jan 9, 2025

Conversation

arvinxx
Copy link
Contributor

@arvinxx arvinxx commented Jan 9, 2025 •
edited
Loading

๐Ÿ’ป ๅ˜ๆ›ด็ฑปๅž‹ | Change Type

  • โœจ feat
  • ๐Ÿ› fix
  • โ™ป๏ธ refactor
  • ๐Ÿ’„ style
  • ๐Ÿ‘ท build
  • โšก๏ธ perf
  • ๐Ÿ“ docs
  • ๐Ÿ”จ chore

๐Ÿ”€ ๅ˜ๆ›ด่ฏดๆ˜Ž | Description of Change

้”ๅฎš [email protected] ไปฅไฟฎๅคๅœจ Safari ๅ†…ๆ ธ็‰ˆๆœฌ 16.4 ๅŠไปฅไธ‹็š„้—ฎ้ข˜

๐Ÿ“ ่กฅๅ……ไฟกๆฏ | Additional Information

refs: syntax-tree/mdast-util-gfm-autolink-literal#10

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jan 9, 2025
@vercel Vercel
Copy link

vercel bot commented Jan 9, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git โ†—๏ธŽ

Name Status Preview Comments Updated (UTC)
lobe-chat-database โœ… Ready (Inspect) Visit Preview Jan 9, 2025 4:24am
lobe-chat-preview โœ… Ready (Inspect) Visit Preview ๐Ÿ’ฌ Add feedback Jan 9, 2025 4:24am

@lobehubbot
Copy link
Member

๐Ÿ‘ @arvinxx

Thank you for raising your pull request and contributing to our Community
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.
If you encounter any problems, please feel free to connect with us.
้žๅธธๆ„Ÿ่ฐขๆ‚จๆๅ‡บๆ‹‰ๅ–่ฏทๆฑ‚ๅนถไธบๆˆ‘ไปฌ็š„็คพๅŒบๅšๅ‡บ่ดก็Œฎ๏ผŒ่ฏท็กฎไฟๆ‚จๅทฒ็ป้ตๅพชไบ†ๆˆ‘ไปฌ็š„่ดก็ŒฎๆŒ‡ๅ—๏ผŒๆˆ‘ไปฌไผšๅฐฝๅฟซๅฎกๆŸฅๅฎƒใ€‚
ๅฆ‚ๆžœๆ‚จ้‡ๅˆฐไปปไฝ•้—ฎ้ข˜๏ผŒ่ฏท้šๆ—ถไธŽๆˆ‘ไปฌ่”็ณปใ€‚

@dosubot dosubot bot added the ๐Ÿ› Bug Something isn't working | ็ผบ้™ท label Jan 9, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 9, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests โœ…

Project coverage is 91.70%. Comparing base (2c3331a) to head (a5ccb4f).
Report is 4 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff            @@
##             main    #5357     +/-   ##
=========================================
  Coverage   91.70%   91.70%             
=========================================
  Files         591      591             
  Lines       46060    46060             
  Branches     4179     2834   -1345     
=========================================
  Hits        42240    42240             
  Misses       3820     3820
Flag Coverage ฮ”
app 91.70% <รธ> (รธ)
server 98.01% <รธ> (รธ)

Flags with carried forward coverage won't be shown. Click here to find out more.

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

@canisminor1990 canisminor1990 changed the title fix build ๐Ÿ› fix: fix remark gfm regex breaks in Safari versions < 16.4 Jan 9, 2025
@canisminor1990 canisminor1990 linked an issue Jan 9, 2025 that may be closed by this pull request
[Bug] Error since v1.45.0 #5352
Open
@canisminor1990 canisminor1990 removed a link to an issue Jan 9, 2025
[Bug] Error since v1.45.0 #5352
Open
@arvinxx arvinxx merged commit 9086570 into main Jan 9, 2025
11 checks passed
@arvinxx arvinxx deleted the fix/ios-16 branch January 9, 2025 04:26
@lobehubbot
Copy link
Member

โค๏ธ Great PR @arvinxx โค๏ธ

The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world.
้กน็›ฎ็š„ๆˆ้•ฟ็ฆปไธๅผ€็”จๆˆทๅ้ฆˆๅ’Œ่ดก็Œฎ๏ผŒๆ„Ÿ่ฐขๆ‚จ็š„่ดก็Œฎ! ๅฆ‚ๆžœๆ‚จๅฏน LobeHub ๅผ€ๅ‘่€…็คพๅŒบๆ„Ÿๅ…ด่ถฃ๏ผŒ่ฏทๅŠ ๅ…ฅๆˆ‘ไปฌ็š„ discord๏ผŒ็„ถๅŽ็งไฟก @arvinxx ๆˆ– @canisminor1990ใ€‚ไป–ไปฌไผš้‚€่ฏทๆ‚จๅŠ ๅ…ฅๆˆ‘ไปฌ็š„็งๅฏ†ๅผ€ๅ‘่€…้ข‘้“ใ€‚ๆˆ‘ไปฌๅฐ†ไผš่ฎจ่ฎบๅ…ณไบŽ Lobe Chat ็š„ๅผ€ๅ‘๏ผŒๅˆ†ไบซๅ’Œ่ฎจ่ฎบๅ…จ็ƒ่Œƒๅ›ดๅ†…็š„ AI ๆถˆๆฏใ€‚

github-actions bot pushed a commit that referenced this pull request Jan 9, 2025
@semantic-release-bot
๐Ÿ”– chore(release): v1.45.1 [skip ci]
552d3fb 
### [Version&nbsp;1.45.1](v1.45.0...v1.45.1)
<sup>Released on **2025-01-09**</sup>

#### ๐Ÿ› Bug Fixes

- **misc**: Fix remark gfm regex breaks in Safari versions < 16.4.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### What's fixed

* **misc**: Fix remark gfm regex breaks in Safari versions < 16.4, closes [#5357](#5357) ([9086570](9086570))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
@lobehubbot
Copy link
Member

๐ŸŽ‰ This PR is included in version 1.45.1 ๐ŸŽ‰

The release is available on:

Your semantic-release bot ๐Ÿ“ฆ๐Ÿš€

github-actions bot pushed a commit to bentwnghk/lobe-chat that referenced this pull request Jan 9, 2025
@semantic-release-bot
๐Ÿ”– chore(release): v1.87.1 [skip ci]
62bc578 
### [Version&nbsp;1.87.1](v1.87.0...v1.87.1)
<sup>Released on **2025-01-09**</sup>

#### ๐Ÿ› Bug Fixes

- **misc**: Fix remark gfm regex breaks in Safari versions < 16.4, fix some ai provider known issues.

#### ๐Ÿ’„ Styles

- **misc**: Update siliconcloud model list.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### What's fixed

* **misc**: Fix remark gfm regex breaks in Safari versions < 16.4, closes [lobehub#5357](https://github.com/bentwnghk/lobe-chat/issues/5357) ([9086570](9086570))
* **misc**: Fix some ai provider known issues, closes [lobehub#5361](https://github.com/bentwnghk/lobe-chat/issues/5361) ([b2775b5](b2775b5))

#### Styles

* **misc**: Update siliconcloud model list, closes [lobehub#5360](https://github.com/bentwnghk/lobe-chat/issues/5360) ([69085ac](69085ac))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
AirboZH pushed a commit to yuanze-dev/lobe-chat that referenced this pull request Jan 9, 2025
@arvinxx @AirboZH
๐Ÿ› fix: fix remark gfm regex breaks in Safari versions < 16.4 (lobehubโ€ฆ
f8838dc 
โ€ฆ#5357)

* fix build

* fix build
AirboZH pushed a commit to yuanze-dev/lobe-chat that referenced this pull request Jan 9, 2025
@semantic-release-bot @AirboZH
๐Ÿ”– chore(release): v1.45.1 [skip ci]
cdc80d6 
### [Version&nbsp;1.45.1](lobehub/lobe-chat@v1.45.0...v1.45.1)
<sup>Released on **2025-01-09**</sup>

#### ๐Ÿ› Bug Fixes

- **misc**: Fix remark gfm regex breaks in Safari versions < 16.4.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### What's fixed

* **misc**: Fix remark gfm regex breaks in Safari versions < 16.4, closes [lobehub#5357](lobehub#5357) ([9086570](lobehub@9086570))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
๐Ÿ› Bug Something isn't working | ็ผบ้™ท released size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arvinxx @lobehubbot