ci: Upload failed MacVim tests artifacts, misc improvements #1522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ychin
added
Infrastructure
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Add new step to upload MacVim test results when we have failed tests. The xcresult folder can be opened in Xcode for inspection to help understand what went wrong. Also, fix the ordering so failed Vim GUI test artifacts can be uploaded as well. When configuring Vim, be explicit to not build with sodium/gettext for the non-publish builds. This makes sure that even if the CI environment somehow has them installed by default, we won't use them by mistake. Those installed packages would be built for a different OS target anyway and throw out warnings (the ones we bundle with MacVim are custom built to target the proper OS versions).
ychin
force-pushed
the
ci-upload-failed-macvim-tests
branch
2 times, most recently
from
2f510ac to
5b30e66
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add MacVim test failure results to the list of failed artifacts to upload. The xcresult folder can be opened in Xcode for inspection to help understand what went wrong. Also, fix the ordering so failed Vim GUI test artifacts can be uploaded as well.
When configuring Vim, be explicit to not build with sodium/gettext for the non-publish builds. This makes sure that even if the CI environment somehow has them installed by default, we won't use them by mistake. Those installed packages would be built for a different OS target anyway and throw out warnings (the ones we bundle with MacVim are custom built to target the proper OS versions).