Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve data explorer UI layout #4115

Merged
merged 3 commits into from
Jan 9, 2025
Merged

Improve data explorer UI layout #4115

merged 3 commits into from
Jan 9, 2025

Conversation

seancolsen
Copy link
Contributor

Overview

This PR

  • Moves the Data Explorer status bar below both sidebars
  • Moves the refresh button into the status bar (to match the Table Page).
  • Removes some arguably superfluous UI that felt especially awkward after moving the refresh button

Fixes #3183

Also helps mitigate #2354

Data Explorer

Before

image

After

image

Exploration Page

Before

image

After

image

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the develop branch of the repository
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@seancolsen seancolsen added this to the v0.2.0 (beta release) milestone Jan 7, 2025
@seancolsen seancolsen added the pr-status: review A PR awaiting review label Jan 7, 2025
@seancolsen
Copy link
Contributor Author

@pavish please review code changes and UI/UX.

@ghislaineguerin please take a look at the UI changes here to make sure you're okay with them.

@seancolsen
Copy link
Contributor Author

@ghislaineguerin and I went over this on a call and she said she's good with these changes.

Copy link
Member

@pavish pavish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@seancolsen Two minor comments, not worth blocking the PR - I'll leave it upto you to make changes/merge:

  1. I noticed an edge case involving the refresh button:
    • Open an existing exploration.
    • Edit it by clicking the 'Edit in Data Explorer' button.
    • The exploration must have some results of rows. Notice the status bar showing pagination as expected.
    • Screenshot 2025-01-09 at 4 55 04 PM
    • Delete all columns.
    • Notice that in the status bar on the bottom, only the "Refresh" button is present.
    • Screenshot 2025-01-08 at 7 58 05 PM
    • Now, click the "Refresh" button.
    • Notice that the pagination components are present again even though there are no results.
    • Screenshot 2025-01-09 at 4 55 28 PM
    • This is because the API actually returns rows with empty objects with the count.
    • This is not an issue that arose from changes in this PR and the reason we didn't encounter this before is because the Refresh button was not present when there were no columns selected/no results.
    • We might want to consider hiding the Refresh button or making it disabled when there are no columns.
  2. Since the placement of the status bar is quite similar to the table page now, it would be good if we made the height consistent in both pages.

@pavish pavish assigned seancolsen and unassigned pavish Jan 9, 2025
@pavish pavish added pr-status: revision A PR awaiting follow-up work from its author after review and removed pr-status: review A PR awaiting review labels Jan 9, 2025
Use the same padding for table page vs data explorer. This makes them
the same height.
@seancolsen
Copy link
Contributor Author

Thanks @pavish

  • I pushed 95ec390 to hide the refresh button when there are no columns. Nice catch!

  • I pushed 04192ab to make the status bars the same height.

@seancolsen seancolsen enabled auto-merge January 9, 2025 15:45
@seancolsen seancolsen added this pull request to the merge queue Jan 9, 2025
Merged via the queue into develop with commit b287684 Jan 9, 2025
70 checks passed
@seancolsen seancolsen deleted the 3183_refresh_button branch January 9, 2025 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-status: revision A PR awaiting follow-up work from its author after review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refresh button should be in a consistent location
3 participants