-
-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve data explorer UI layout #4115
Conversation
@pavish please review code changes and UI/UX. @ghislaineguerin please take a look at the UI changes here to make sure you're okay with them. |
@ghislaineguerin and I went over this on a call and she said she's good with these changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@seancolsen Two minor comments, not worth blocking the PR - I'll leave it upto you to make changes/merge:
- I noticed an edge case involving the refresh button:
- Open an existing exploration.
- Edit it by clicking the 'Edit in Data Explorer' button.
- The exploration must have some results of rows. Notice the status bar showing pagination as expected.
- Delete all columns.
- Notice that in the status bar on the bottom, only the "Refresh" button is present.
- Now, click the "Refresh" button.
- Notice that the pagination components are present again even though there are no results.
- This is because the API actually returns rows with empty objects with the count.
- This is not an issue that arose from changes in this PR and the reason we didn't encounter this before is because the Refresh button was not present when there were no columns selected/no results.
- We might want to consider hiding the Refresh button or making it disabled when there are no columns.
- Since the placement of the status bar is quite similar to the table page now, it would be good if we made the height consistent in both pages.
Use the same padding for table page vs data explorer. This makes them the same height.
Overview
This PR
Fixes #3183
Also helps mitigate #2354
Data Explorer
Before
After
Exploration Page
Before
After
Checklist
Update index.md
).develop
branch of the repositoryDeveloper Certificate of Origin
Developer Certificate of Origin