Enable Mock DigiD IDP callback validation in production #1543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swrichards
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1543 +/- ##
========================================
Coverage 94.13% 94.13%
========================================
Files 1064 1064
Lines 39286 39287 +1
========================================
+ Hits 36982 36983 +1
Misses 2304 2304 ☔ View full report in Codecov by Sentry. |
swrichards
changed the title
swrichards
force-pushed
the
tasks/2961-bump-django-digid-eherkenning-and-simple-certmanager
branch
from
974f6c4 to
39dc541
Compare
pi-sigma
approved these changes
Jan 9, 2025
swrichards
force-pushed
the
tasks/2961-bump-django-digid-eherkenning-and-simple-certmanager
branch
from
39dc541 to
89c56f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taiga.
Note that the version bump of
django-digid-eherkenningis sufficient: the validation flag is set to the inverse ofDEBUG, so on public facing instances, callbacks should be validated as the debug flag won't be set.