Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CANBus api first revision #3

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

CANBus api first revision #3

wants to merge 14 commits into from

Conversation

roeyb1
Copy link
Contributor

@roeyb1 roeyb1 commented Nov 19, 2022

Supported features:

  • Transmit message on the canbus
  • Receive message from the canbus
  • filter messages into one of two fifos based on ids or filter masks
  • descriptive error handling
  • extensive inline documentation along with usage sample in the readme

@roeyb1 roeyb1 self-assigned this Nov 19, 2022
acoulombe
acoulombe reviewed Nov 22, 2022
View reviewed changes
lib/CAN/Can.cpp Outdated Show resolved Hide resolved
lib/CAN/Can.cpp Outdated Show resolved Hide resolved
acoulombe
acoulombe previously approved these changes Nov 26, 2022
View reviewed changes
lib/CAN/Can.cpp Outdated Show resolved Hide resolved
@roeyb1 roeyb1 requested a review from acoulombe November 26, 2022 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acoulombe acoulombe acoulombe approved these changes

@vboucher07 vboucher07 Awaiting requested review from vboucher07

@allisonmazurek allisonmazurek Awaiting requested review from allisonmazurek allisonmazurek is a code owner

@FelixGuilbertSavary FelixGuilbertSavary Awaiting requested review from FelixGuilbertSavary FelixGuilbertSavary is a code owner

@rsaif22 rsaif22 Awaiting requested review from rsaif22 rsaif22 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@roeyb1 roeyb1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@roeyb1 @acoulombe