Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Created up/down tilt for arms control #8

Open
wants to merge 1 commit into
base: arm-controls
Choose a base branch
from

Conversation

ExoPrisma
Copy link

@ExoPrisma ExoPrisma commented Nov 22, 2024

Description
  Added implementation of up/down tilt by taking the current pose and computing a new pose with a modified pitch (up or down) and returning the pose after IK.

Issues

  • Increment of pitch might not be the most optimal way.
  • Naming of button (3 for L2 and 4 for R2) might not be optimal.
  • Might need to recheck clamping to make sure that the joint taken is the right one.

Assumptions

  • Assume that value is normalized between -1.0 and 1.0.
  • Assume that L2 points down and R2 points up (relative to the current orientation).

Code has not been tested yet

Copy link
Contributor

@aerin-brown-codes aerin-brown-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, but since Euler angles get pretty complicated, I'd like it if you added a couple unit tests in the test file. For example, test what happens when you give input at the limits. Also do a general case test by running the new angles through forward kinematics to make sure you're still getting the position you would expect (i.e. the hand_pose you're passing to the IK). That way we can make sure changes are as expected and no weird Euler angle stuff is causing IK to break down before we do sim testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants