Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New page: DOMMatrixReadOnly.flipY() #37171

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

New page: DOMMatrixReadOnly.flipY() #37171

wants to merge 5 commits into from

Conversation

estelle
Copy link
Member

@estelle estelle commented Dec 10, 2024

@estelle estelle requested a review from a team as a code owner December 10, 2024 19:48
@estelle estelle requested review from wbamberg and removed request for a team December 10, 2024 19:48
@github-actions github-actions bot added Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed labels Dec 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 10, 2024 •
edited
Loading

Preview URLs

Flaws (1)

Note! 1 document with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/DOMMatrixReadOnly/flipY
Title: DOMMatrixReadOnly: flipY() method
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/API/DOMMatrixReadOnly/isIdentity

(comment last updated: 2025-01-08 09:43:06)

@bsmth bsmth self-requested a review January 8, 2025 09:41
@bsmth
Copy link
Member

bsmth commented Jan 8, 2025

Having a look now in case Will doesn't get to it first :)

Karinza38

This comment was marked as spam.

Sign in to view

bsmth
bsmth reviewed Jan 8, 2025
View reviewed changes
files/en-us/web/api/dommatrixreadonly/flipy/index.md

#### JavaScript

The JavaScript creates an [identity matrix](/en-US/docs/Web/API/DOMMatrixReadOnly/isIdentity), then uses the `flipY()` method to create a new matrix, which is then applied to the blue triangle, inverting it across the y-axis. The red triangle is left in place.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this doc coming soon? Currently broken link

bsmth
bsmth reviewed Jan 8, 2025
View reviewed changes
files/en-us/web/api/dommatrixreadonly/flipy/index.md

#### Result

{{EmbedLiveSample('Inverting a triangle')}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a big deal, but there's a vertical scrollbar here.

bsmth
bsmth approved these changes Jan 8, 2025
View reviewed changes
Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two comments, but looking good, thanks! Leaving a +1 so you can merge when ready

@wbamberg wbamberg removed their request for review January 9, 2025 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Karinza38 Karinza38 Karinza38 left review comments

@bsmth bsmth bsmth approved these changes

Assignees
No one assigned
Labels
Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@estelle @bsmth @Karinza38