generalize deepspeed linear and implement it for non cuda systems #6932
+208
−56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oelayan7
requested review from
tohtana,
tjruwase,
loadams and
jomayeri
as code owners
loadams
reviewed
Jan 8, 2025
op_builder/fp_quantizer.py
Outdated
| @@ -9,6 +9,7 @@ | |||
| pkg_version = None | |||
|
|
|||
| from .builder import CUDAOpBuilder, installed_cuda_version | |||
| import torch | |||
There was a problem hiding this comment.
Could you wrap this in a try/except, similar to other imports of torch inside op_builder? Not having this prevents us from building the whl in an environment where torch isn't installed (this will fix the no-torch workflow).
There was a problem hiding this comment.
@loadams I moved it inside the function, and imported it locally.
When this function is called, there will always be torch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.