eslint(container-loader): Prefix container-loader before enabling no-unchecked-record-access #23423
+18
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unchecked-record-access
github-actions
bot
added
area: loader
There was a problem hiding this comment.
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
jatgarg
approved these changes
Jan 3, 2025
jason-ha
reviewed
Jan 7, 2025
Comment on lines
-95
to
+97
| baseSnapshot.trees.default.trees.root.unreferenced, | ||
| baseSnapshot.trees.default?.trees.root?.unreferenced, |
There was a problem hiding this comment.
@RishhiB, what do this and other ? additions have to do with no-unchecked-record-access rule?
There was a problem hiding this comment.
I believe its because baseSnapshot.trees is of type [path: string]: ISnapshotTree, so default or root record access may not exist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prefix container-loader before enabling no-unchecked-record-access
AB#26471