Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove scenario-runner #23445

Conversation

sonalideshpandemsft
Copy link
Contributor

This change removes scenario-runner tests. These tests are no longer used in any pipelines or by AFR.

@Copilot Copilot bot review requested due to automatic review settings January 3, 2025 19:21
@github-actions github-actions bot added the base: main PRs targeted against main branch label Jan 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 14 out of 29 changed files in this pull request and generated no comments.

Files not reviewed (15)
  • azure/packages/test/scenario-runner/.gitignore: Language not supported
  • azure/packages/test/scenario-runner/.npmignore: Language not supported
  • azure/packages/test/scenario-runner/LICENSE: Language not supported
  • azure/packages/test/scenario-runner/biome.jsonc: Language not supported
  • azure/packages/test/scenario-runner/configs/nestedMap.yml: Language not supported
  • azure/packages/test/scenario-runner/configs/nestedMap2.yml: Language not supported
  • azure/packages/test/scenario-runner/package.json: Language not supported
  • azure/packages/test/scenario-runner/src/NestedMapRunner.ts: Evaluated as low risk
  • azure/packages/test/scenario-runner/src/interface.ts: Evaluated as low risk
  • azure/packages/test/scenario-runner/src/TestOrchestrator.ts: Evaluated as low risk
  • azure/packages/test/scenario-runner/src/TestDataObject.ts: Evaluated as low risk
  • azure/packages/test/scenario-runner/src/ScenarioRunner.ts: Evaluated as low risk
  • azure/packages/test/scenario-runner/src/AzureClientRunner.ts: Evaluated as low risk
  • azure/packages/test/scenario-runner/src/DocLoaderRunner.ts: Evaluated as low risk
  • azure/packages/test/scenario-runner/src/AzureFunctionTokenProvider.ts: Evaluated as low risk
Copy link
Contributor

github-actions bot commented Jan 3, 2025

🔗 No broken links found! ✅

Your attention to detail is admirable.

linkcheck output


> [email protected] ci:check-links /home/runner/work/FluidFramework/FluidFramework/docs
> start-server-and-test "npm run serve -- --no-open" 3000 check-links

1: starting server using command "npm run serve -- --no-open"
and when url "[ 'http://127.0.0.1:3000' ]" is responding with HTTP status code 200
running tests using command "npm run check-links"


> [email protected] serve
> docusaurus serve --no-open

[SUCCESS] Serving "build" directory at: http://localhost:3000/

> [email protected] check-links
> linkcheck http://localhost:3000 --skip-file skipped-urls.txt

Crawling...

Stats:
  170492 links
    1603 destination URLs
    1838 URLs ignored
       0 warnings
       0 errors


@alexvy86
Copy link
Contributor

alexvy86 commented Jan 3, 2025

Found the PR that removed the pipeline which used the scenario-runner (thank you git log -S scenario-runner --source -- tools/pipelines!), so I think we can be pretty confident we don't use it anymore.

@sonalideshpandemsft sonalideshpandemsft merged commit 102b9b8 into microsoft:main Jan 6, 2025
32 checks passed
@sonalideshpandemsft sonalideshpandemsft deleted the remove-scenario-runner-1 branch January 6, 2025 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
base: main PRs targeted against main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants