-
Notifications
You must be signed in to change notification settings - Fork 535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated Merge-Tree and SharedString ISegment members #23448
Conversation
…to make-segmentgroup-private
…to prototype-merge-infos
…to just-leaf-info
…to just-leaf-info
…to segment-leaf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Coverage Summary
↓ packages.dds.sequence.src:
Branch Coverage Change: -0.01%
Metric Name | Baseline coverage | PR coverage | Coverage Diff |
---|---|---|---|
Branch Coverage | 89.68% | 89.67% | ↓ -0.01% |
↑ packages.dds.merge-tree.src:
Branch Coverage Change: 0.04%
Metric Name | Baseline coverage | PR coverage | Coverage Diff |
---|---|---|---|
Branch Coverage | 94.81% | 94.85% | ↑ 0.04% |
Baseline commit: 237f042
Baseline build: 315358
Happy Coding!!
Code coverage comparison check passed!!
⯅ @fluid-example/bundle-size-tests: +237 Bytes
Baseline commit: 237f042 |
…to test/remove-mt-segment-deprecations
cf8aebf
to
b023708
Compare
…to test/remove-mt-segment-deprecations
…to test/remove-mt-segment-deprecations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a very nitpicky suggestion, but otherwise the docs changes look good!
Co-authored-by: Joshua Smithrud <[email protected]>
🔗 No broken links found! ✅ Your attention to detail is admirable. linkcheck output
|
The current ISegment interface over-exposes a number of properties which do not have an external use case, and any external usage could result in damage to the underlying merge-tree including data corruption.
In Fluid Framework release 2.12.0 these properties and associated types were deprecated.
The only use case that will continue to be supported is determining if a segment is removed. For this purpose we've added the free function
segmentIsRemoved(segment: ISegment): boolean
.For example, checking if a segment is not removed would change as follows:
The following properties are removed from ISegment and its implementations:
Additionally, the following types are also removed:
fixes #23328