Update @fluidframework/test-tools in LTS #23449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexvy86
approved these changes
Jan 6, 2025
Comment on lines
+51
to
+53
| "test:jest": "assign-test-ports --package-manager lerna && lerna run test:jest --concurrency 4 --stream --no-bail --no-sort -- -- --color", | ||
| "test:jest:bail": "assign-test-ports --package-manager lerna && lerna run test:jest --concurrency 4 --stream", | ||
| "test:jest:report": "assign-test-ports --package-manager lerna && lerna run test:jest --concurrency 4 --stream --no-bail --no-sort -- -- --ci --reporters=default --reporters=jest-junit", |
There was a problem hiding this comment.
build-tools doesn't have jest tests. Maybe I, maybe someone else (can't remember 😄), already removed these scripts and the dependency on test-tools in main, so I'd suggest we keep lts lean and remove them here too.
| @@ -44,7 +44,7 @@ | |||
| "@fluidframework/build-common": "^0.24.0", | |||
| "@fluidframework/build-tools": "^0.6.0", | |||
| "@fluidframework/eslint-config-fluid": "^0.28.2000", | |||
| "@fluidframework/test-tools": "^0.2.3074", | |||
| "@fluidframework/test-tools": "^2.0.1", | |||
There was a problem hiding this comment.
Seems unused, let's remove it?
| @@ -46,7 +46,7 @@ | |||
| "devDependencies": { | |||
| "@fluidframework/build-common": "^0.24.0", | |||
| "@fluidframework/eslint-config-fluid": "^0.28.2000", | |||
| "@fluidframework/test-tools": "^0.2.3074", | |||
| "@fluidframework/test-tools": "^2.0.1", | |||
There was a problem hiding this comment.
This one also seems unused.
|
Going to do the removals in follow-ups |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@fluidframework/test-toolsto 2.0.1, usinglernaforassign-test-portsFixes issues making LTS pipelines unhealthy.