Narrow types by typeof operands with extra parenthesis #60928

Andarist · 2025-01-07T10:39:14Z

Andarist · 2025-01-07T10:40:09Z

src/compiler/binder.ts

-                return isNarrowableOperand(expr.left) || isNarrowableOperand(expr.right) ||
-                    isNarrowingTypeofOperands(expr.right, expr.left) || isNarrowingTypeofOperands(expr.left, expr.right) ||
-                    (isBooleanLiteral(expr.right) && isNarrowingExpression(expr.left) || isBooleanLiteral(expr.left) && isNarrowingExpression(expr.right));
+                const left = skipParentheses(expr.left);


I rechecked all of the branches in the containing function. They should all now look through parenthesis - this was the only branch missing this

gabritto · 2025-01-07T18:22:03Z

@typescript-bot test it

typescript-bot · 2025-01-07T18:22:11Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2025-01-07T18:43:47Z

@gabritto Here are the results of running the user tests with tsc comparing main and refs/pull/60928/merge:

Everything looks good!

typescript-bot · 2025-01-07T18:44:33Z

Hey @gabritto, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2025-01-07T19:04:27Z

@gabritto
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₄	₃₄	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,363	_62,363	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,395	_50,395	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{194,830k (± 1.03%)}	_{193,025k (± 0.01%)}	_~	_193,015k	_193,041k	_{p=1.000 n=6}
_{Parse Time}	_{1.31s (± 0.93%)}	_{1.31s (± 0.93%)}	_~	_1.29s	_1.32s	_{p=1.000 n=6}
_{Bind Time}	_{0.72s (± 0.57%)}	_0.73s	_{+0.01s (+ 1.62%)}	_~	_~	_{p=0.002 n=6}
_{Check Time}	_{9.79s (± 0.19%)}	_{9.79s (± 0.19%)}	_~	_9.77s	_9.82s	_{p=0.684 n=6}
_{Emit Time}	_{2.74s (± 0.43%)}	_{2.72s (± 0.23%)}	_{-0.02s (- 0.67%)}	_2.71s	_2.73s	_{p=0.019 n=6}
_{Total Time}	_{14.56s (± 0.13%)}	_{14.54s (± 0.18%)}	_~	_14.51s	_14.59s	_{p=0.414 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₃₇	₃₇	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_947,936	_947,936	_~	_~	_~	_{p=1.000 n=6}
_Types	_410,955	_410,955	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,225,814k (± 0.00%)}	_{1,225,830k (± 0.00%)}	_~	_1,225,802k	_1,225,919k	_{p=0.936 n=6}
_{Parse Time}	_{6.63s (± 0.59%)}	_{6.65s (± 0.71%)}	_~	_6.58s	_6.69s	_{p=0.627 n=6}
_{Bind Time}	_{1.89s (± 0.44%)}	_{1.89s (± 0.29%)}	_{+0.01s (+ 0.53%)}	_1.89s	_1.90s	_{p=0.038 n=6}
_{Check Time}	_{31.99s (± 0.15%)}	_{32.00s (± 0.31%)}	_~	_31.85s	_32.12s	_{p=0.748 n=6}
_{Emit Time}	_{15.19s (± 0.57%)}	_{15.18s (± 0.30%)}	_~	_15.09s	_15.22s	_{p=0.199 n=6}
_{Total Time}	_{55.70s (± 0.26%)}	_{55.72s (± 0.17%)}	_~	_55.62s	_55.87s	_{p=0.872 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,446,493	_2,446,493	_~	_~	_~	_{p=1.000 n=6}
_Types	_897,066	_897,066	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,311,166k (± 0.00%)}	_{2,311,143k (± 0.00%)}	_~	_2,311,102k	_2,311,190k	_{p=0.521 n=6}
_{Parse Time}	_{8.96s (± 0.46%)}	_{8.95s (± 0.23%)}	_~	_8.91s	_8.97s	_{p=0.685 n=6}
_{Bind Time}	_{2.13s (± 0.89%)}	_{2.12s (± 0.64%)}	_~	_2.10s	_2.14s	_{p=0.510 n=6}
_{Check Time}	_{73.11s (± 0.36%)}	_{72.95s (± 0.34%)}	_~	_72.65s	_73.27s	_{p=0.575 n=6}
_{Emit Time}	_{0.28s (± 1.82%)}	_{0.28s (± 2.70%)}	_~	_0.27s	_0.29s	_{p=0.241 n=6}
_{Total Time}	_{84.49s (± 0.32%)}	_{84.31s (± 0.28%)}	_~	_84.00s	_84.55s	_{p=0.470 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,226,880	_1,226,882	_{+2 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_266,745	_266,745	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,417,994k (± 6.14%)}	_{2,418,472k (± 6.13%)}	_{+478k (+ 0.02%)}	_2,357,600k	_2,721,208k	_{p=0.045 n=6}
_{Parse Time}	_{5.24s (± 0.98%)}	_{5.21s (± 1.47%)}	_~	_5.10s	_5.32s	_{p=0.689 n=6}
_{Bind Time}	_{1.77s (± 0.66%)}	_{1.79s (± 0.91%)}	_~	_1.77s	_1.81s	_{p=0.085 n=6}
_{Check Time}	_{35.17s (± 0.50%)}	_{35.14s (± 0.88%)}	_~	_34.56s	_35.43s	_{p=0.873 n=6}
_{Emit Time}	_{2.99s (± 2.64%)}	_{2.97s (± 1.37%)}	_~	_2.90s	_3.02s	_{p=1.000 n=6}
_{Total Time}	_{45.17s (± 0.47%)}	_{45.12s (± 0.71%)}	_~	_44.54s	_45.42s	_{p=0.936 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,226,880	_1,226,882	_{+2 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_266,745	_266,745	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,790,457k (±14.24%)}	_{3,032,969k (± 9.74%)}	_~	_2,429,131k	_3,154,236k	_{p=0.173 n=6}
_{Parse Time}	_{8.55s (± 1.96%)}	_{8.59s (± 0.97%)}	_~	_8.46s	_8.68s	_{p=0.810 n=6}
_{Bind Time}	_{2.69s (± 2.12%)}	_{2.67s (± 1.46%)}	_~	_2.60s	_2.71s	_{p=0.227 n=6}
_{Check Time}	_{53.07s (± 0.21%)}	_{53.04s (± 0.38%)}	_~	_52.69s	_53.25s	_{p=0.810 n=6}
_{Emit Time}	_{4.41s (± 2.09%)}	_{4.36s (± 1.36%)}	_~	_4.28s	_4.45s	_{p=0.378 n=6}
_{Total Time}	_{68.73s (± 0.41%)}	_{68.67s (± 0.40%)}	_~	_68.17s	_68.94s	_{p=0.810 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_262,439	_262,441	_{+2 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_106,628	_106,628	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{440,216k (± 0.02%)}	_{440,199k (± 0.02%)}	_~	_440,096k	_440,279k	_{p=0.936 n=6}
_{Parse Time}	_{3.53s (± 0.93%)}	_{3.53s (± 1.20%)}	_~	_3.47s	_3.57s	_{p=0.687 n=6}
_{Bind Time}	_{1.32s (± 0.93%)}	_{1.30s (± 0.64%)}	_~	_1.29s	_1.31s	_{p=0.209 n=6}
_{Check Time}	_{19.01s (± 0.30%)}	_{18.92s (± 0.45%)}	_{-0.09s (- 0.50%)}	_18.77s	_19.00s	_{p=0.045 n=6}
_{Emit Time}	_{1.54s (± 1.39%)}	_{1.54s (± 0.89%)}	_~	_1.52s	_1.56s	_{p=1.000 n=6}
_{Total Time}	_{25.39s (± 0.25%)}	_{25.30s (± 0.38%)}	_~	_25.14s	_25.42s	_{p=0.092 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₇₀	₇₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_226,062	_226,062	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,488	_94,488	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{371,640k (± 0.04%)}	_{371,751k (± 0.06%)}	_~	_371,588k	_372,171k	_{p=0.128 n=6}
_{Parse Time}	_{3.62s (± 1.28%)}	_{3.61s (± 0.70%)}	_~	_3.57s	_3.64s	_{p=0.225 n=6}
_{Bind Time}	_{1.95s (± 0.72%)}	_{1.96s (± 0.53%)}	_~	_1.95s	_1.98s	_{p=0.086 n=6}
_{Check Time}	_{20.45s (± 0.20%)}	_{20.47s (± 0.10%)}	_~	_20.45s	_20.49s	_{p=0.565 n=6}
_{Emit Time}	_{0.00s (±244.70%)}	_0.00s	_~	_~	_~	_{p=0.405 n=6}
_{Total Time}	_{26.02s (± 0.19%)}	_{26.05s (± 0.10%)}	_~	_26.03s	_26.09s	_{p=0.226 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₃	₃	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_3,233,660	_3,233,660	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,113,001	_1,113,001	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,296,711k (± 0.01%)}	_{3,297,113k (± 0.01%)}	_~	_3,296,572k	_3,297,420k	_{p=0.128 n=6}
_{Parse Time}	_{14.08s (± 0.13%)}	_{14.13s (± 0.55%)}	_~	_14.03s	_14.26s	_{p=0.198 n=6}
_{Bind Time}	_{4.54s (± 2.42%)}	_{4.62s (± 3.30%)}	_~	_4.46s	_4.77s	_{p=0.809 n=6}
_{Check Time}	_{87.41s (± 1.38%)}	_{88.24s (± 3.27%)}	_~	_86.07s	_93.67s	_{p=0.689 n=6}
_{Emit Time}	_{28.58s (± 2.36%)}	_{27.76s (± 2.55%)}	_~	_27.12s	_28.71s	_{p=0.054 n=6}
_{Total Time}	_{134.61s (± 0.44%)}	_{134.74s (± 2.04%)}	_~	_131.98s	_139.82s	_{p=0.471 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_291,562	_291,562	_~	_~	_~	_{p=1.000 n=6}
_Types	_118,971	_118,971	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{445,271k (± 0.01%)}	_{445,370k (± 0.03%)}	_~	_445,223k	_445,529k	_{p=0.128 n=6}
_{Parse Time}	_{4.09s (± 0.87%)}	_{4.08s (± 1.68%)}	_~	_3.97s	_4.17s	_{p=1.000 n=6}
_{Bind Time}	_{1.78s (± 1.35%)}	_{1.78s (± 0.46%)}	_~	_1.77s	_1.79s	_{p=0.682 n=6}
_{Check Time}	_{18.75s (± 0.35%)}	_{18.80s (± 0.26%)}	_~	_18.75s	_18.87s	_{p=0.332 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{24.61s (± 0.22%)}	_{24.65s (± 0.45%)}	_~	_24.50s	_24.79s	_{p=0.688 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_555,017	_555,017	_~	_~	_~	_{p=1.000 n=6}
_Types	_186,115	_186,115	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{494,037k (± 0.01%)}	_{493,959k (± 0.03%)}	_~	_493,649k	_494,101k	_{p=0.471 n=6}
_{Parse Time}	_{3.42s (± 0.71%)}	_{3.41s (± 1.00%)}	_~	_3.37s	_3.45s	_{p=0.567 n=6}
_{Bind Time}	_{1.18s (± 1.31%)}	_{1.17s (± 1.21%)}	_~	_1.15s	_1.19s	_{p=0.324 n=6}
_{Check Time}	_{19.56s (± 0.42%)}	_{19.80s (± 2.89%)}	_~	_19.49s	_20.96s	_{p=0.748 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{24.16s (± 0.34%)}	_{24.38s (± 2.40%)}	_~	_24.03s	_25.56s	_{p=0.936 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2025-01-07T20:04:24Z

@gabritto Here are the results of running the top 400 repos with tsc comparing main and refs/pull/60928/merge:

Everything looks good!

Narrow types by typeof operands with extra parenthesis

199f492

typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Jan 7, 2025

Andarist commented Jan 7, 2025

View reviewed changes

gabritto approved these changes Jan 7, 2025

View reviewed changes

JoostK mentioned this pull request Jan 7, 2025

Type check in @if (and *ngIf) causes compiler errors while linter passes angular/angular#59215

Open

gabritto approved these changes Jan 7, 2025

View reviewed changes

gabritto merged commit a5196c7 into microsoft:main Jan 7, 2025
32 checks passed

Andarist deleted the narrow-typeof-extra-parens branch January 7, 2025 20:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Narrow types by typeof operands with extra parenthesis #60928

Narrow types by typeof operands with extra parenthesis #60928

Andarist commented Jan 7, 2025

Andarist Jan 7, 2025

gabritto commented Jan 7, 2025

typescript-bot commented Jan 7, 2025 •

edited

Loading

typescript-bot commented Jan 7, 2025

typescript-bot commented Jan 7, 2025

typescript-bot commented Jan 7, 2025

tsc

typescript-bot commented Jan 7, 2025

Narrow types by typeof operands with extra parenthesis #60928

Narrow types by typeof operands with extra parenthesis #60928

Conversation

Andarist commented Jan 7, 2025

Andarist Jan 7, 2025

Choose a reason for hiding this comment

gabritto commented Jan 7, 2025

typescript-bot commented Jan 7, 2025 • edited Loading

typescript-bot commented Jan 7, 2025

typescript-bot commented Jan 7, 2025

typescript-bot commented Jan 7, 2025

tsc

typescript-bot commented Jan 7, 2025

typescript-bot commented Jan 7, 2025 •

edited

Loading