Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add titlebar height setting sample #1711

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

InfyniteHeap
Copy link

Description

Provide a sample to demonstrate how to set the height of titlebar after extending contents into titlebar.

Motivation and Context

WinUI supports to set titlebar height, but the TitleBar page doesn't contain a sample to that.

How Has This Been Tested?

Just build and run this app, and trun to TitleBar page, and then test whether the combobox works as expected.

Screenshots (if appropriate):

屏幕截图 2024-12-24 222750
屏幕截图 2024-12-24 222754
屏幕截图 2024-12-24 222757

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@Jay-o-Way
Copy link
Contributor

Is this based on on the new experimental titlebar control (coming hopefully in WASDK 1.7) maybe? I think there's an issue with the phrasing like "... now allows ..." It is unclear what "now" means: is it a SDK version, a specific date or something else? And if it relies on a SDK version, this must be clearly mentioned.
Also, after a while - "now" will become outdated at some point in time.

Besides that: try and keep redundancy to a minimum and use normal sentence casing (see "Titlebar customizations")

Zakariathr22

This comment was marked as resolved.

Co-authored-by: Mgg Sk <[email protected]>
@karkarl
Copy link
Collaborator

karkarl commented Jan 9, 2025

/azp run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants