Add json schema generation tool #59
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Roaa Sakr <[email protected]>
Signed-off-by: Roaa Sakr <[email protected]>
Signed-off-by: Roaa Sakr <[email protected]>
Signed-off-by: Roaa Sakr <[email protected]>
Signed-off-by: Roaa Sakr <[email protected]>
liulanze
reviewed
Jan 3, 2025
cwize1
requested changes
Jan 6, 2025
| @@ -66,6 +67,13 @@ func (s *PartitionSize) UnmarshalJSON(data []byte) error { | |||
| return parseAndSetPartitionSize(stringValue, s) | |||
| } | |||
|
|
|||
| func (PartitionSize) JSONSchema() *jsonschema.Schema { | |||
There was a problem hiding this comment.
You'll probably want a JSONSchema function on each type that has a UnmarshalYAML function.
|
|
||
| BINARY_NAME := bin/imagecustomizerschemacli | ||
| GO_FILES := $(wildcard *.go) | ||
| SCHEMA_FILE := schema.json |
There was a problem hiding this comment.
Should this schema.json be checked-in?
There was a problem hiding this comment.
Yes, I'm planning to but will do that in a separate change. The other change will include adding a github workflow to ensure this file is kept up to date with any change/PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a cli that generates image customizer API json schema.
The generated schema file can be leveraged by other tools for API dependency and config validation.
Here's an example using it in VSCode for syntax validation:
Checklist