Skip to content

Commit

Permalink
ci(.github): disable invalid secrets variables within custom composit…
Browse files Browse the repository at this point in the history
…e gh action
  • Loading branch information
Hotell committed Dec 31, 2024
1 parent abb7ba3 commit 4768a9f
Showing 1 changed file with 23 additions and 24 deletions.
47 changes: 23 additions & 24 deletions .github/actions/run-publish-vr-screenshot/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -86,20 +86,19 @@ runs:
# ==========================================================
# STEPS BELOW WILL FAIL TO RUN ON GITHUB ACTIONS - see TODOs
# ==========================================================

# TODO: will need Federated Identity to be added to tool similarly like we have for monosize azure plugin https://github.com/microsoft/monosize/blob/main/packages/monosize-storage-azure/src/createTableClient.mts#L27
- name: VR App - Create Policy
if: ${{ env.isPR == 'true' }}
shell: bash
run: |
set -exuo pipefail
npx [email protected] create-policy --nonBlockingPipelines '{"${{ env.pipelineId }}":{"pipelineStatus": "PENDING","pipelineName": "${{ env.pipelineName }}"}}' --clientType 'FLUENTUI'
env:
VR_APP_API_URL: ${{ secrets.VR_APP_API_URL }}
TENANT_ID: ${{ secrets.TenantId }}
PRINCIPAL_CLIENT_ID: ${{ secrets.PrincipalClientId }}
SERVICE_CONNECTION_ID: ${{ secrets.ServiceConnectionId }}
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
# env:
# VR_APP_API_URL: ${{ secrets.VR_APP_API_URL }}
# TENANT_ID: ${{ secrets.TenantId }}
# PRINCIPAL_CLIENT_ID: ${{ secrets.PrincipalClientId }}
# SERVICE_CONNECTION_ID: ${{ secrets.ServiceConnectionId }}
# GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

# TODO: will need azure/login@v2 to be added to the workflow {@ling file://./../../workflows/pr-website-deploy-comment.yml#49}
- name: Run screenshotdiff
Expand All @@ -109,14 +108,14 @@ runs:
# ciDefinitionId is set to 205 because that is the ID of the baseline pipeline (https://uifabric.visualstudio.com/fabricpublic/_build?definitionId=205) used by the master branch
# TODO: not sure how this will be used on GHA cc @evancharlton @TristanWatanabe
CI_DEFINITION_ID: 205
API_TOKEN: ${{ secrets.fabric-public-pipeline-access-PAT }}
GITHUB_API_TOKEN: ${{ secrets.githubRepoStatusPAT }}
VR_APP_API_URL: ${{ secrets.VR_APP_API_URL }}
STORAGE_ACCOUNT_ID: ${{ secrets.StorageAccountId }}
TENANT_ID: ${{ secrets.TenantId }}
PRINCIPAL_CLIENT_ID: ${{ secrets.PrincipalClientId }}
SERVICE_CONNECTION_ID: ${{ secrets.ServiceConnectionId }}
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
# API_TOKEN: ${{ secrets.fabric-public-pipeline-access-PAT }}
# GITHUB_API_TOKEN: ${{ secrets.githubRepoStatusPAT }}
# VR_APP_API_URL: ${{ secrets.VR_APP_API_URL }}
# STORAGE_ACCOUNT_ID: ${{ secrets.StorageAccountId }}
# TENANT_ID: ${{ secrets.TenantId }}
# PRINCIPAL_CLIENT_ID: ${{ secrets.PrincipalClientId }}
# SERVICE_CONNECTION_ID: ${{ secrets.ServiceConnectionId }}
# GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
azcliversion: latest
inlineScript: |
Expand All @@ -126,15 +125,15 @@ runs:
- name: Run screenshotdiff - update baseline (non PR)
if: ${{ github.event_name != 'pull_request' }}
uses: azure/cli@v2
env:
API_TOKEN: ${{ secrets.fabric-public-pipeline-access-PAT }}
GITHUB_API_TOKEN: ${{ secrets.githubRepoStatusPAT }}
VR_APP_API_URL: ${{ secrets.VR_APP_API_URL }}
STORAGE_ACCOUNT_ID: ${{ secrets.StorageAccountId }}
TENANT_ID: ${{ secrets.TenantId }}
PRINCIPAL_CLIENT_ID: ${{ secrets.PrincipalClientId }}
SERVICE_CONNECTION_ID: ${{ secrets.ServiceConnectionId }}
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
# env:
# API_TOKEN: ${{ secrets.fabric-public-pipeline-access-PAT }}
# GITHUB_API_TOKEN: ${{ secrets.githubRepoStatusPAT }}
# VR_APP_API_URL: ${{ secrets.VR_APP_API_URL }}
# STORAGE_ACCOUNT_ID: ${{ secrets.StorageAccountId }}
# TENANT_ID: ${{ secrets.TenantId }}
# PRINCIPAL_CLIENT_ID: ${{ secrets.PrincipalClientId }}
# SERVICE_CONNECTION_ID: ${{ secrets.ServiceConnectionId }}
# GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
azcliversion: latest
inlineScript: |
Expand Down

0 comments on commit 4768a9f

Please sign in to comment.