Fixes for test app crashes for 12 schema data #33542
Conversation
📊 Bundle size report✅ No changes found |
|
Pull request demo site: URL |
| @@ -65,6 +66,35 @@ export const updateXValues = (xValues: any[]): any[] => { | |||
| }); | |||
| return xValues; | |||
| }; | |||
|
|
|||
| function parseDateFromString(dateString: string): Date | null { | |||
There was a problem hiding this comment.
no this is for the cases if the dateString is of any format like "2021 Q1". If it contains date string, parseDateFromString will then parse it and return the date.
There was a problem hiding this comment.
what is the output for 2021 Q1
There was a problem hiding this comment.
for data: "x": [
"2020 Q1",
"2020 Q2",
"2020 Q3",
"2020 Q4",
"2021 Q1",
"2021 Q2",
"2021 Q3",
"2021 Q4",
"2022 Q1",
"2022 Q2"
],
"y": [75, 78, 80, 82, 85, 88, 90, 92, 95, 97],
There was a problem hiding this comment.
I am not getting what is 2020 Q2 getting transformed into. What line of code is doing this conversion.
There was a problem hiding this comment.
Every year if present is getting extracted as it is without the Q2 and created as a Date. For "2020 Q2" it is new Date(2020) as well as for "2020 Q3".
There was a problem hiding this comment.
This is not correct. Q1, Q2, Q3, Q4 should have different x values. In such case we can fall back on vertical stacked bar chart and render x value as string.
There was a problem hiding this comment.
Since the string can be anything like "2021 Quater1" or something else, the entire string cannot be used to convert to a unique Date string. So, falling back would be best here.
Fixes for test app crashes for 12 schema data
Fixed schema data numbers 84, 85, 88, 91, 92, 93, 99, 100, 101, 102, 103, 107