Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvement/33473 react toast styling #33550

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Improvement/33473 react toast styling #33550

wants to merge 7 commits into from
+14 −1

Conversation

soumyart
Copy link

@soumyart soumyart commented Jan 5, 2025 •
edited
Loading

New Behavior

  1. intent property in Toast state.
  2. Correct media className assignment in useToastTitleStyles

Related Issue(s)

@soumyart soumyart marked this pull request as ready for review January 5, 2025 12:37
@soumyart soumyart requested a review from a team as a code owner January 5, 2025 12:37
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 6, 2025 •
edited
Loading

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-components
react-components: entire library		 1.164 MB
291.227 kB		 1.164 MB
291.23 kB		 36 B
3 B
react-toast
Toast (including Toaster)		 101.23 kB
30.429 kB		 101.371 kB
30.477 kB		 141 B
48 B
Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-components
react-components: Button, FluentProvider & webLightTheme		 69.21 kB
20.174 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover		 222.703 kB
64.42 kB
react-components
react-components: FluentProvider & webLightTheme		 44.447 kB
14.59 kB
react-portal-compat
PortalCompatProvider		 8.39 kB
2.64 kB
react-timepicker-compat
TimePicker		 108.525 kB
36.087 kB
🤖 This report was generated against aa6e5ddc04518065cd0a25bcdd5c91d2c1615bbd

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 6, 2025

Pull request demo site: URL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@layershifter layershifter layershifter left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Component: Toast
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature]: react-toast: Access to intent property in Toast component
2 participants
@soumyart @layershifter