-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Event Queue Completion Refactor #4732
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4732 +/- ##
==========================================
- Coverage 87.20% 86.52% -0.68%
==========================================
Files 56 56
Lines 17363 17378 +15
==========================================
- Hits 15141 15037 -104
- Misses 2222 2341 +119 ☔ View full report in Codecov by Sentry. |
ami-GS
reviewed
Jan 6, 2025
ami-GS
reviewed
Jan 6, 2025
ami-GS
reviewed
Jan 6, 2025
ami-GS
previously approved these changes
Jan 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice change
mtfriesen
previously approved these changes
Jan 6, 2025
guhetier
reviewed
Jan 6, 2025
guhetier
reviewed
Jan 6, 2025
mtfriesen
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactors the CxPlat event queue interface to have completions execute callback functions instead of call hardcoded functions with type value.
Testing
Existing CI/CD
Documentation
N/A - Internal (for now)