More use of CMAKE_INSTALL_<...>DIR #4738
Merged
+18
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CMAKE_INSTALL_INCLUDEDIR is already used for the exported build interface. This change applies the standard variables to more destinations, moves the related GNUInstallDirs include to the top-level CMakeLists.txt, and adds explicit RUNTIME/LIBRARY/ARCHIVE destinations. This should be beneficial for external packaging. Last not least put msquic.lttng into the msquic CMake export set.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4738 +/- ##
==========================================
- Coverage 85.71% 85.61% -0.10%
==========================================
Files 56 56
Lines 17378 17378
==========================================
- Hits 14896 14879 -17
- Misses 2482 2499 +17 ☔ View full report in Codecov by Sentry. |
nibanks
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CMAKE_INSTALL_INCLUDEDIRis already used for the exported build interface. This change applies the standard variables to more destinations, moves the relatedGNUInstallDirsmodule to the top-level CMakeLists.txt, and adds explicitRUNTIME/LIBRARY/ARCHIVEdestinations. This should be beneficial for external packaging. (vcpkg needsRUNTIME DESTINATION.)Last not least put
msquic.lttnginto the msquic CMake export set.Testing
Affects packaging - not tested.
Documentation
This PR changes the install destination of the DLLs. It might deserve an announcement when released.