Update start stop activity computer to support OpenTelemetry-Sdk EventSource #2139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OpenTelemetry-SDK event source
pharring
reviewed
Jan 6, 2025
pharring
suggested changes
Jan 7, 2025
pharring
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The OpenTelemetry SDK event source is emitting request start/stop information, but the format differs from what TraceEvent expects for start/stop operations. This mismatch prevents proper recognition of activities in the CallTree view.
This change introduces an exception to accommodate the OpenTelemetry SDK’s event format, ensuring that start/stop activities are correctly recognized and displayed in the CallTree view.
Details:
For reference, see the implementation in the OpenTelemetry SDK:
OpenTelemetrySdkEventSource.cs
Before the change:
After the change:
Tagging @brianrob for awareness.