Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Prepare CI to properly run Electron on ubuntu-latest (24.04) #34238

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

agg23
Copy link
Contributor

@agg23 agg23 commented Jan 7, 2025

GitHub Actions updated the ubuntu-latest tag to point to Ubuntu 24.04 without much of an announcement (see actions/runner-images#10636). This included removing several required packages for running Electron, causing our Electron smoke tests to fail.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@agg23 agg23 added the CQ1 label Jan 7, 2025

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Jan 7, 2025

Test results for "tests others"

1 flaky ⚠️ [chromium-library] › tests/library/browsertype-connect.spec.ts:575:5 › run-server › should properly disconnect when connection closes from the client side @realtime-time-library-chromium-linux

21455 passed, 503 skipped
✔️✔️✔️

Merge workflow run.

Copy link
Contributor

github-actions bot commented Jan 7, 2025

Test results for "tests 2"

2 fatal errors, not part of any test
23 failed
❌ [chromium-library] › tests/library/browsertype-connect.spec.ts:667:5 › run-server › should fulfill with global fetch result @chrome-beta-macos-latest
❌ [chromium-library] › tests/library/inspector/cli-codegen-2.spec.ts:456:7 › cli codegen › should --save-trace @chrome-beta-macos-latest
❌ [chromium-library] › tests/library/browsertype-connect.spec.ts:735:5 › run-server › setInputFiles should preserve lastModified timestamp @chrome-macos-latest
❌ [chromium-library] › tests/library/browsertype-connect.spec.ts:838:7 › run-server › socks proxy › should proxy local.playwright requests @chrome-macos-latest
❌ [chromium-library] › tests/library/inspector/cli-codegen-2.spec.ts:456:7 › cli codegen › should --save-trace @chrome-macos-latest
❌ [chromium-library] › tests/library/inspector/cli-codegen-2.spec.ts:466:7 › cli codegen › should save assets via SIGINT @chrome-macos-latest
❌ [chromium-library] › tests/library/inspector/cli-codegen-csharp.spec.ts:171:5 › should work with --save-har @chrome-macos-latest
❌ [chromium-library] › tests/library/inspector/cli-codegen-csharp.spec.ts:182:5 › should work with --save-har and --save-har-glob @chrome-macos-latest
❌ [chromium-library] › tests/library/inspector/cli-codegen-pytest.spec.ts:57:5 › should save the codegen output to a file if specified @chrome-macos-latest
❌ [chromium-library] › tests/library/inspector/cli-codegen-pytest.spec.ts:73:5 › should work with --save-har @chrome-macos-latest
❌ [chromium-library] › tests/library/inspector/cli-codegen-python-async.spec.ts:82:5 › should save the codegen output to a file if specified @chrome-macos-latest
❌ [chromium-library] › tests/library/inspector/cli-codegen-python-async.spec.ts:147:5 › should work with --save-har @chrome-macos-latest
❌ [firefox-library] › tests/library/video.spec.ts:189:5 › screencast › should capture static page @firefox-headed-windows-latest
❌ [chromium-library] › tests/library/downloads-path.spec.ts:105:5 › downloads path › should delete downloads when persistent context closes @msedge-beta-macos-latest
❌ [installation tests] › tests/playwright-electron-should-work.spec.ts:21:5 › electron should work @package-installations-ubuntu-latest-node20
❌ [installation tests] › tests/playwright-electron-should-work.spec.ts:31:5 › electron should work with special characters in path @package-installations-ubuntu-latest-node20
❌ [installation tests] › tests/playwright-electron-should-work.spec.ts:44:5 › should work when wrapped inside @playwright/test and trace is enabled @package-installations-ubuntu-latest-node20
❌ [installation tests] › tests/playwright-electron-should-work.spec.ts:21:5 › electron should work @package-installations-ubuntu-latest-node22
❌ [installation tests] › tests/playwright-electron-should-work.spec.ts:31:5 › electron should work with special characters in path @package-installations-ubuntu-latest-node22
❌ [installation tests] › tests/playwright-electron-should-work.spec.ts:44:5 › should work when wrapped inside @playwright/test and trace is enabled @package-installations-ubuntu-latest-node22
❌ [webkit-library] › tests/library/trace-viewer.spec.ts:1580:1 › should show a popover @webkit-macos-13-xlarge
❌ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames fit @webkit-macos-13-xlarge
❌ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-13-xlarge

113 flaky ⚠️ [chromium-library] › tests/library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @channel-chromium-macos-latest
⚠️ [chromium-library] › tests/library/browsercontext-fetch.spec.ts:1229:3 › should work with connectOverCDP @channel-chromium-macos-latest
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-2.spec.ts:456:7 › cli codegen › should --save-trace @channel-chromium-macos-latest
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-3.spec.ts:171:7 › cli codegen › should generate frame locators (4) @channel-chromium-windows-latest
⚠️ [chromium-library] › tests/library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto @chrome-beta-macos-latest
⚠️ [chromium-library] › tests/library/browsercontext-fetch.spec.ts:1229:3 › should work with connectOverCDP @chrome-beta-macos-latest
⚠️ [chromium-library] › tests/library/browsertype-connect.spec.ts:838:7 › run-server › socks proxy › should proxy local.playwright requests @chrome-beta-macos-latest
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-csharp.spec.ts:171:5 › should work with --save-har @chrome-beta-macos-latest
⚠️ [chromium-library] › tests/library/browsercontext-proxy.spec.ts:27:3 › should work when passing the proxy only on the context level @chrome-macos-latest
⚠️ [chromium-library] › tests/library/browsertype-connect.spec.ts:853:7 › run-server › socks proxy › should lead to the error page for forwarded requests when the connection is refused @chrome-macos-latest
⚠️ [chromium-library] › tests/library/browsertype-launch.spec.ts:107:3 › should accept objects as options @chrome-macos-latest
⚠️ [chromium-library] › tests/library/chromium/tracing.spec.ts:21:3 › should output a trace @chrome-macos-latest
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-java.spec.ts:105:5 › should work with --save-har and --save-har-glob as java-junit @chrome-macos-latest
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-javascript.spec.ts:87:5 › should save the codegen output to a file if specified @chrome-macos-latest
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-pytest.spec.ts:84:5 › should work with --save-har and --save-har-glob @chrome-macos-latest
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-python-async.spec.ts:158:5 › should work with --save-har and --save-har-glob @chrome-macos-latest
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-test.spec.ts:112:5 › should generate routeFromHAR with --save-har and --save-har-glob @chrome-macos-latest
⚠️ [chromium-library] › tests/library/inspector/pause.spec.ts:23:3 › should resume when closing inspector @chrome-macos-latest
⚠️ [chromium-library] › tests/library/video.spec.ts:581:5 › screencast › should capture static page in persistent context @smoke @chrome-windows-latest
⚠️ [chromium-library] › tests/library/trace-viewer.spec.ts:1474:1 › should not leak recorders @chromium-headed-ubuntu-24.04
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-3.spec.ts:733:7 › cli codegen › should assert value on disabled input @chromium-headed-windows-latest
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-pick-locator.spec.ts:36:7 › should update locator highlight @chromium-headed-windows-latest
⚠️ [chromium-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames crop @chromium-macos-13-large
⚠️ [chromium-library] › tests/library/trace-viewer.spec.ts:1221:1 › should pick locator in iframe @chromium-macos-14-large
⚠️ [chromium-page] › tests/page/page-event-request.spec.ts:138:3 › should report navigation requests and responses handled by service worker with routing @chromium-tip-of-tree-headless-shell-ubuntu-20.04
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:206:1 › should reset mouse position @chromium-tip-of-tree-ubuntu-20.04--headed
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-1.spec.ts:727:7 › cli codegen › should attribute navigation to click @chromium-tip-of-tree-ubuntu-20.04--headed
⚠️ [chromium-library] › tests/library/inspector/pause.spec.ts:522:5 › pause › should record from debugger @chromium-tip-of-tree-ubuntu-20.04--headed
⚠️ [chromium-library] › tests/library/tap.spec.ts:22:3 › should send all of the correct events @smoke @chromium-tip-of-tree-ubuntu-20.04--headed
⚠️ [chromium-library] › tests/library/trace-viewer.spec.ts:911:1 › should show action source @chromium-tip-of-tree-ubuntu-20.04--headed
⚠️ [chromium-page] › tests/page/page-event-request.spec.ts:110:3 › should report navigation requests and responses handled by service worker @chromium-tip-of-tree-ubuntu-20.04--headed
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-beta-ubuntu-20.04
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-beta-windows-latest
⚠️ [firefox-library] › tests/library/capabilities.spec.ts:252:3 › requestFullscreen @firefox-headed-macos-14-xlarge
⚠️ [firefox-library] › tests/library/video.spec.ts:381:5 › screencast › should capture navigation @firefox-headed-macos-14-xlarge
⚠️ [firefox-page] › tests/page/page-add-locator-handler.spec.ts:230:5 › should work when owner frame detaches @firefox-headed-macos-14-xlarge
⚠️ [firefox-page] › tests/page/page-click-scroll.spec.ts:55:3 › should scroll into view display:contents with a child @firefox-headed-ubuntu-24.04
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-headed-ubuntu-24.04
⚠️ [firefox-library] › tests/library/browsercontext-cookies.spec.ts:407:3 › should parse cookie with large Max-Age correctly @firefox-headed-windows-latest
⚠️ [firefox-library] › tests/library/browsercontext-har.spec.ts:415:3 › should ignore boundary when matching multipart/form-data body @firefox-headed-windows-latest
⚠️ [firefox-library] › tests/library/download.spec.ts:231:5 › download event › should error when saving with downloads disabled @firefox-headed-windows-latest
⚠️ [firefox-library] › tests/library/download.spec.ts:258:5 › download event › should report non-navigation downloads @firefox-headed-windows-latest
⚠️ [firefox-library] › tests/library/download.spec.ts:354:5 › download event › should expose stream @firefox-headed-windows-latest
⚠️ [firefox-library] › tests/library/inspector/cli-codegen-2.spec.ts:456:7 › cli codegen › should --save-trace @firefox-headed-windows-latest
⚠️ [firefox-library] › tests/library/locator-generator.spec.ts:192:3 › reverse engineer getByRole @firefox-headed-windows-latest
⚠️ [firefox-library] › tests/library/page-clock.spec.ts:43:3 › runFor › triggers immediately without specified delay @firefox-headed-windows-latest
⚠️ [firefox-library] › tests/library/tracing.spec.ts:164:5 › should include context API requests @firefox-headed-windows-latest
⚠️ [firefox-library] › tests/library/tracing.spec.ts:263:5 › should not include trace resources from the previous chunks @firefox-headed-windows-latest
⚠️ [firefox-library] › tests/library/tracing.spec.ts:400:5 › should not stall on dialogs @firefox-headed-windows-latest
⚠️ [firefox-library] › tests/library/unroute-behavior.spec.ts:20:3 › context.unroute should not wait for pending handlers to complete @firefox-headed-windows-latest
⚠️ [firefox-page] › tests/page/page-click-timeout-3.spec.ts:39:3 › should timeout waiting for hit target @firefox-headed-windows-latest
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-headed-windows-latest
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-macos-13-large
⚠️ [firefox-library] › tests/library/inspector/cli-codegen-aria.spec.ts:77:7 › should update aria snapshot highlight @firefox-macos-13-xlarge
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-macos-14-large
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-20.04
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-24.04
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-windows-latest
⚠️ [chromium-library] › tests/library/beforeunload.spec.ts:20:3 › should close browser with beforeunload page @msedge-beta-macos-latest
⚠️ [chromium-library] › tests/library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @msedge-beta-macos-latest
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-beta-macos-latest
⚠️ [chromium-library] › tests/library/browsertype-launch-server.spec.ts:36:5 › launch server › should work with port @msedge-beta-macos-latest
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-2.spec.ts:456:7 › cli codegen › should --save-trace @msedge-beta-macos-latest
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-2.spec.ts:466:7 › cli codegen › should save assets via SIGINT @msedge-beta-macos-latest
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-csharp.spec.ts:216:7 › should work with --save-har in mstest @msedge-beta-macos-latest
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-beta-ubuntu-20.04
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-test.spec.ts:74:5 › should print load storageState @msedge-beta-ubuntu-20.04
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-beta-windows-latest
⚠️ [chromium-library] › tests/library/beforeunload.spec.ts:20:3 › should close browser with beforeunload page @msedge-dev-macos-latest
⚠️ [chromium-library] › tests/library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @msedge-dev-macos-latest
⚠️ [chromium-library] › tests/library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto @msedge-dev-macos-latest
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-dev-macos-latest
⚠️ [chromium-library] › tests/library/browsertype-launch-server.spec.ts:43:5 › launch server › should work with wsPath @msedge-dev-macos-latest
⚠️ [chromium-library] › tests/library/headful.spec.ts:114:3 › should close browser after context menu was triggered @msedge-dev-macos-latest
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-2.spec.ts:456:7 › cli codegen › should --save-trace @msedge-dev-macos-latest
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-csharp.spec.ts:171:5 › should work with --save-har @msedge-dev-macos-latest
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-test.spec.ts:112:5 › should generate routeFromHAR with --save-har and --save-har-glob @msedge-dev-macos-latest
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-dev-ubuntu-20.04
⚠️ [chromium-page] › tests/page/page-event-request.spec.ts:138:3 › should report navigation requests and responses handled by service worker with routing @msedge-dev-ubuntu-20.04
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-macos-latest
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-2.spec.ts:456:7 › cli codegen › should --save-trace @msedge-macos-latest
⚠️ [chromium-library] › tests/library/logger.spec.ts:19:3 › should log @smoke @msedge-macos-latest
⚠️ [chromium-library] › tests/library/proxy.spec.ts:93:11 › should proxy local network requests › with other bypasses › localhost @msedge-macos-latest
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-ubuntu-20.04
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-windows-latest
⚠️ [chromium-library] › tests/library/video.spec.ts:381:5 › screencast › should capture navigation @tracing-chromium-tip-of-tree
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @tracing-firefox
⚠️ [webkit-library] › tests/library/browsercontext-device.spec.ts:45:5 › device › should scroll to click @tracing-webkit
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-1.spec.ts:611:7 › cli codegen › should select @webkit-headed-macos-14-xlarge
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-1.spec.ts:56:7 › cli codegen › should double click @webkit-headed-ubuntu-20.04
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-1.spec.ts:299:7 › cli codegen › should fill japanese text @webkit-headed-ubuntu-22.04
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-3.spec.ts:498:7 › cli codegen › should generate getByAltText @webkit-headed-ubuntu-22.04
⚠️ [webkit-library] › tests/library/browsercontext-reuse.spec.ts:206:1 › should reset mouse position @webkit-headed-windows-latest
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-1.spec.ts:97:7 › cli codegen › should ignore programmatic events @webkit-headed-windows-latest
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-1.spec.ts:685:7 › cli codegen › should await popup @webkit-headed-windows-latest
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-1.spec.ts:727:7 › cli codegen › should attribute navigation to click @webkit-headed-windows-latest
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-1.spec.ts:930:7 › cli codegen › should clear when recording is disabled @webkit-headed-windows-latest
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-3.spec.ts:686:7 › cli codegen › should assert value @webkit-headed-windows-latest
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-aria.spec.ts:121:7 › should show aria snapshot error @webkit-headed-windows-latest
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-pick-locator.spec.ts:36:7 › should update locator highlight @webkit-headed-windows-latest
⚠️ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-13-xlarge
⚠️ [webkit-library] › tests/library/trace-viewer.spec.ts:1524:1 › canvas clipping @webkit-macos-14-xlarge
⚠️ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames fit @webkit-macos-14-xlarge
⚠️ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-14-xlarge
⚠️ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-14-xlarge
⚠️ [webkit-library] › tests/library/trace-viewer.spec.ts:1524:1 › canvas clipping @webkit-macos-15-xlarge
⚠️ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-15-xlarge
⚠️ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-15-xlarge
⚠️ [webkit-page] › tests/page/page-request-continue.spec.ts:254:5 › post data › should amend binary post data @webkit-macos-15-xlarge
⚠️ [webkit-library] › tests/library/browsertype-connect.spec.ts:755:5 › run-server › should connect over http @webkit-ubuntu-20.04
⚠️ [webkit-library] › tests/library/browsercontext-reuse.spec.ts:50:1 › should reset serviceworker @webkit-windows-latest
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-aria.spec.ts:77:7 › should update aria snapshot highlight @webkit-windows-latest
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-pick-locator.spec.ts:36:7 › should update locator highlight @webkit-windows-latest

253336 passed, 9732 skipped
✔️✔️✔️

Merge workflow run.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Jan 8, 2025

Test results for "tests 1"

6 flaky ⚠️ [firefox-library] › tests/library/trace-viewer.spec.ts:1512:1 › should serve css without content-type @firefox-ubuntu-22.04-node18
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18
⚠️ [installation tests] › tests/typescript-types.spec.ts:18:5 › typescript types should work @package-installations-windows-latest
⚠️ [webkit-library] › tests/library/proxy.spec.ts:44:3 › should use proxy for second page @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/tracing.spec.ts:370:5 › should survive browser.close with auto-created traces dir @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › tests/page/page-set-input-files.spec.ts:147:3 › should upload large file @webkit-ubuntu-22.04-node18

37545 passed, 649 skipped
✔️✔️✔️

Merge workflow run.

@agg23 agg23 added CQ1 and removed CQ1 labels Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants