Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding QR codes support in the ImageRedactorEngine #1036
base: main
Are you sure you want to change the base?
Adding QR codes support in the ImageRedactorEngine #1036
Changes from 25 commits
5600a52
4a6832a
6112513
9511480
72a51f3
ad81ade
3977ebb
2e3ca74
ecd403c
b78dffd
a5a32fd
3c3fee9
8f170c8
984286f
2a53628
ac97022
2bc39bb
007e0d9
1de5f94
f248581
843ef17
17aff14
e29f0e0
bb8095c
8ac62fb
4975682
98a7d1a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If
QRImageAnalyzerEngine
inherits fromImageAnalyzerEngine
, then this class could be independent of the QR implementationThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@omri374 @vpvpvpvp Any idea on making it more open-close?
Maybe a single ImageAnalyzerEngine that we inherit from with optional **ocr_kwargs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In case of direct inheritance of
QRImageAnalyzerEngine
fromImageAnalyzerEngine
, it would only need to add ocr_kwars to the analyze method ofQRImageAnalyzerEngine
. This is probably the easiest way.Potentially, it seems like the most optimal implementation when
ImageAnalyzerEngine
is used for orchestrating different recognizers (ocr recognizer, QR recognizer, etc.). In the vein of what was suggested earlier #1036 (comment).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this class be inherited from
ImageAnalyzerEngine
? Just a question, to see if we can simplify the design instead of extending it to a new set of independent classes.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was thinking exactly the same, see below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it can be inherited from
ImageAnalyzerEngine
. My concern is that in this case,QRImageAnalyzerEngine
will also inherit the logic of working with ocr tools not related to QR code recognition.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that's my concern too. As the package is still in beta, we should (carefully) consider breaking backward compatibility. We'll do some thinking on this and get back to you. We can also have a quick design session together over video if you're interested.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that sounds interesting. If you have time, we could do that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. To avoid putting personal emails on GH, could you please email [email protected] and we'll continue the discussion over email?