Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed python 3.8 support (EOL) and added 3.12 #1479

Merged
merged 7 commits into from
Nov 4, 2024
Merged

Conversation

omri374
Copy link
Contributor

@omri374 omri374 commented Nov 2, 2024

Change Description

  1. Python 3.8 EOL date is 2024-10-07. Removed 3.8 and added 3.12
  2. removed obsolete version parameter from docker-compose
    Fixes issue Support for newer Python versions (3.12.x and 3.13.x) #1473
  3. Fixed failing e2e test (demo website text validation, also updated the demo website's text)

@omri374 omri374 requested a review from a team as a code owner November 2, 2024 15:28
@omri374 omri374 changed the title Removed 3.8 and added 3.12 Removed python 3.8 support (EOL) and added 3.12 Nov 2, 2024
@omri374
Copy link
Contributor Author

omri374 commented Nov 2, 2024

/azp run

Copy link

Azure Pipelines failed to run 1 pipeline(s).

@omri374
Copy link
Contributor Author

omri374 commented Nov 2, 2024

@SharonHart the pipeline is failing due to torch not supporting python 3.8 any longer. Could you please review?

@omri374 omri374 merged commit 33808c2 into main Nov 4, 2024
32 checks passed
@omri374 omri374 deleted the update_py_version branch November 4, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants