Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable tracing in Promptflow by default #3907

Merged
merged 15 commits into from
Jan 7, 2025
Merged

Disable tracing in Promptflow by default #3907

merged 15 commits into from
Jan 7, 2025

Conversation

ninghu
Copy link
Member

@ninghu ninghu commented Jan 7, 2025

Description

Tracing frequently causes problems because OAI/AOAI keeps changing token statistics contracts. Disabling this feature to prevent these issues.

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • I confirm that all new dependencies are compatible with the MIT license.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

Copy link

github-actions bot commented Jan 7, 2025

promptflow SDK CLI Azure E2E Test Result ninhu/disable_tracing

  3 files    3 suites   3m 20s ⏱️
244 tests 154 ✅  40 💤  37 ❌ 13 🔥
732 runs  462 ✅ 120 💤 111 ❌ 39 🔥

For more details on these failures and errors, see this check.

Results for commit 4898ba8.

♻️ This comment has been updated with latest results.

@ninghu ninghu merged commit 3c3c72f into main Jan 7, 2025
58 of 69 checks passed
@ninghu ninghu deleted the ninhu/disable_tracing branch January 7, 2025 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants