Switch DataTestMethod to TestMethod #849
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #849 +/- ##
=======================================
Coverage 46.47% 46.47%
=======================================
Files 355 355
Lines 14151 14151
Branches 1163 1163
=======================================
Hits 6577 6577
Misses 7026 7026
Partials 548 548 ☔ View full report in Codecov by Sentry. |
DaveTryon
reviewed
Jan 2, 2025
| @@ -100,7 +100,6 @@ public void MissingPropertiesTest_ThrowsSHA256() | |||
| Assert.ThrowsException<ParserException>(() => result.Files.Select(f => f.ToSbomFile()).ToList()); | |||
| } | |||
|
|
|||
| [DataTestMethod] | |||
There was a problem hiding this comment.
For consistency, can you please put the [TestMethod] attribute before the DataRow attributes for the tests in this file?
DaveTryon
reviewed
Jan 2, 2025
| @@ -40,7 +40,6 @@ public void StreamEmptyTestReturnsNull() | |||
| var result = this.Parse(parser); | |||
| } | |||
|
|
|||
| [DataTestMethod] | |||
There was a problem hiding this comment.
For consistency, can you please put the [TestMethod] attribute before the DataRow attributes for the tests in this file?
DaveTryon
requested changes
Jan 2, 2025
There was a problem hiding this comment.
Thanks for the PR, @Youssef1313! I've requested a minor change just to follow consistent formatting in the test layout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DataTestMethodAttribute is functionally the same as TestMethodAttribute and they are interchangeable. Using DataTestMethodAttribute is no longer recommended and may be dropped in MSTest v4.