-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[freerdp] update to 3.10.2 and fix absolute paths #43150
base: master
Are you sure you want to change the base?
Conversation
+#define WINPR_INSTALL_PREFIX "" | ||
+#define WINPR_INSTALL_SYSCONFDIR "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@akallabeth, These two lines of macros contain absolute paths. I searched the upstream code and found no other place where these two macros are used. Do you mind if I modify them this way?
F:\test\vcpkg\ports\freerdp\portfile.cmake: warning: There should be no absolute paths, such as the following, in an installed package. To suppress this message, add set(VCPKG_POLICY_SKIP_ABSOLUTE_PATHS_CHECK enabled)
note: F:\test\vcpkg\packages
note: F:\test\vcpkg\installed
note: F:\test\vcpkg\buildtrees
note: F:\test\vcpkg\downloads
F:\test\vcpkg\packages\freerdp_x64-windows\include\winpr3\winpr\build-config.h: note: absolute paths found here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, it breaks file loading (used for keyboard layouts, timezones and other stuff if enabled)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have any good suggestions? Thank you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you enable these features (loading stuff from files)?
if not the macro is unused.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't have those features enabled, so it was a warning, but the vcpkg policy clearly stated that absolute paths were not allowed, so I tried fixing it.
Fixes #43093
The "supports" clause reflects platforms that may be fixed by this new version.Any fixed CI baseline entries are removed from that file../vcpkg x-add-version --all
and committing the result.tested usage successfully by
freerdp:x64-windows
.