Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[freerdp] update to 3.10.2 and fix absolute paths #43150

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

JonLiu1993
Copy link
Member

Fixes #43093

  1. Update port version to 3.10.2
  2. Fix absolute paths
F:\test\vcpkg\ports\freerdp\portfile.cmake: warning: There should be no absolute paths, such as the following, in an installed package. To suppress this message, add set(VCPKG_POLICY_SKIP_ABSOLUTE_PATHS_CHECK enabled)
note: F:\test\vcpkg\packages
note: F:\test\vcpkg\installed
note: F:\test\vcpkg\buildtrees
note: F:\test\vcpkg\downloads
  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

tested usage successfully by freerdp:x64-windows.

@JonLiu1993 JonLiu1993 added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. category:port-update The issue is with a library, which is requesting update new revision labels Jan 7, 2025
Comment on lines +11 to +12
+#define WINPR_INSTALL_PREFIX ""
+#define WINPR_INSTALL_SYSCONFDIR ""
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akallabeth, These two lines of macros contain absolute paths. I searched the upstream code and found no other place where these two macros are used. Do you mind if I modify them this way?

F:\test\vcpkg\ports\freerdp\portfile.cmake: warning: There should be no absolute paths, such as the following, in an installed package. To suppress this message, add set(VCPKG_POLICY_SKIP_ABSOLUTE_PATHS_CHECK enabled)
note: F:\test\vcpkg\packages
note: F:\test\vcpkg\installed
note: F:\test\vcpkg\buildtrees
note: F:\test\vcpkg\downloads
F:\test\vcpkg\packages\freerdp_x64-windows\include\winpr3\winpr\build-config.h: note: absolute paths found here

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it breaks file loading (used for keyboard layouts, timezones and other stuff if enabled)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have any good suggestions? Thank you.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you enable these features (loading stuff from files)?
if not the macro is unused.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't have those features enabled, so it was a warning, but the vcpkg policy clearly stated that absolute paths were not allowed, so I tried fixing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support category:port-update The issue is with a library, which is requesting update new revision info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[freerdp] update to 3.10.2
3 participants