code snippet provider #13018
code snippet provider #13018
Conversation
Extension/src/LanguageServer/copilotCompletionContextProvider.ts
Outdated
Show resolved
Hide resolved
Extension/src/LanguageServer/copilotCompletionContextProvider.ts
Outdated
Show resolved
Hide resolved
Extension/src/LanguageServer/copilotCompletionContextProvider.ts
Outdated
Show resolved
Hide resolved
Extension/src/LanguageServer/copilotCompletionContextProvider.ts
Outdated
Show resolved
Hide resolved
|
|
||
| export async function registerCopilotContextProvider(): Promise<void> { | ||
| try { | ||
| const isCustomSnippetProviderApiEnabled = await telemetry.isExperimentEnabled("CppToolsCustomSnippetsApi"); |
There was a problem hiding this comment.
We can't do audience filtering and set this flag at the same time. Instead, on the Copilot side you'll need to modify the construction of activeExperiments in CompletionContext to check for the experiment, then update the resolver here to respect activeExperiments.
Alternatively, if the intent of this check was to act as a kill-switch then you can leave it as-is (although we'll still need the activeExperiments plumbing). We'll just need to be sure that CppToolsCustomSnippetsApi is at 100% rollout for all VS Code traffic before starting the actual experiment.
Extension/src/LanguageServer/copilotCompletionContextProvider.ts
Outdated
Show resolved
Hide resolved
Extension/src/LanguageServer/copilotCompletionContextProvider.ts
Outdated
Show resolved
Hide resolved
|
@lukka Soon you should be able to take a dependency on https://www.npmjs.com/package/@github/copilot-language-server to get appropriate typings. The types aren't quite there yet, but https://github.com/github/copilot-client/pull/6250 is adding them. |
lukka
force-pushed
the
dev/lucappa/cop-ctx-api
branch
2 times, most recently
from
991df60 to
22235f3
Compare
Extension/src/LanguageServer/copilotCompletionContextProvider.ts
Outdated
Show resolved
Hide resolved
Extension/src/LanguageServer/copilotCompletionContextProvider.ts
Outdated
Show resolved
Hide resolved
Extension/src/LanguageServer/copilotCompletionContextProvider.ts
Outdated
Show resolved
Hide resolved
Extension/src/LanguageServer/copilotCompletionContextProvider.ts
Outdated
Show resolved
Hide resolved
Extension/src/LanguageServer/copilotCompletionContextProvider.ts
Outdated
Show resolved
Hide resolved
Extension/src/LanguageServer/copilotCompletionContextProvider.ts
Outdated
Show resolved
Hide resolved
lukka
force-pushed
the
dev/lucappa/cop-ctx-api
branch
from
22235f3 to
0679bab
Compare
lukka
force-pushed
the
dev/lucappa/cop-ctx-api
branch
from
0679bab to
b996200
Compare
This is done, thanks! |
lukka
force-pushed
the
dev/lucappa/cop-ctx-api
branch
from
b996200 to
a7f8949
Compare
lukka
force-pushed
the
dev/lucappa/cop-ctx-api
branch
from
a7f8949 to
d1876a2
Compare
| @@ -6573,6 +6573,7 @@ | |||
| "xml2js": "^0.6.2" | |||
| }, | |||
| "dependencies": { | |||
| "@github/copilot-language-server": "^1.253.0", | |||
There was a problem hiding this comment.
@lukka There's a 1.254.0 currently -- should we switch to that one instead. Do you know how important it is to update this? I'm guessing it might be important since it's so new?
There was a problem hiding this comment.
Also, unlike most packages, there appears to be no publicly available changelog so I can't tell what's different, i.e. if anything important got fixed/changed.
No description provided.