Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): update chokidar to v4 #5256

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

chore(deps): update chokidar to v4 #5256

wants to merge 3 commits into from
+360 −113

Conversation

ggodlewski
Copy link

@ggodlewski ggodlewski commented Nov 16, 2024 •
edited by JoshuaKGoldberg
Loading

PR Checklist

Overview

Current chokidar is bundled with tons of spam deps including braces which trigger some audit alert.

Uploading image.png…

All test are working. It supports globs unlike #5215

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Nov 16, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@alexparish alexparish mentioned this pull request Dec 1, 2024
Open
JoshuaKGoldberg
JoshuaKGoldberg requested changes Jan 2, 2025
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey thanks for getting this started! Sorry it took so long to review - since Chokidar didn't end up needing to be bumped with v11, this fell by the wayside. But I'm excited to help push this forward along now! 🚀

Requesting changes primarily on a performance point, as well as a design point. Happy to talk if you want. 🙂

lib/cli/watch-run.js Outdated Show resolved Hide resolved
lib/cli/watch-run.js Outdated Show resolved Hide resolved
lib/cli/watch-run.js Outdated Show resolved Hide resolved
@JoshuaKGoldberg JoshuaKGoldberg added the status: waiting for author waiting on response from OP - more information needed label Jan 2, 2025
@ggodlewski
Copy link
Author

Hey @JoshuaKGoldberg, there is no way I remember the details after a month :). All I know it's been a struggle to get all tests working. In the meantime we switched to ava to resolve our issues, so I can't do much.
I updated the code to fix your issues. If there is anything that I can do fast let me know.

@Uzlopak Uzlopak changed the title chore(deps): update choikdar to v4 chore(deps): update chokidar to v4 Jan 2, 2025
@talentlessguy
Copy link

@JoshuaKGoldberg is there any blocker to this PR besides merge conflicts of a lockfile?

@JoshuaKGoldberg
Copy link
Member

Just a re-request for review. I'll add it to the queue for review :)

@JoshuaKGoldberg JoshuaKGoldberg added status: needs review a maintainer should (re-)review this pull request and removed status: waiting for author waiting on response from OP - more information needed labels Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
status: needs review a maintainer should (re-)review this pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Chore: bump chokidar to v4
3 participants
@ggodlewski @talentlessguy @JoshuaKGoldberg