Clarify quantity #3634
Open
Clarify quantity #3634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on comment in modelica#3626
henrikt-ma
reviewed
Jan 7, 2025
chapters/connectors.tex
Outdated
| @@ -599,6 +599,10 @@ \section{Restrictions of Connections and Connectors}\label{restrictions-of-conne | |||
| \end{nonnormative} | |||
| \item\label{connect-set-quantity-rule}\index{quantity@\robustinline{quantity}!connect set rule} | |||
| In a connection set, all variables having non-empty \lstinline!quantity!-attribute must have the same \lstinline!quantity!-attribute. | |||
| \begin{nonnormative} | |||
| Note that variables with different quantities may be unit-compatible, in particular Work and Torque. | |||
There was a problem hiding this comment.
Let's not mix in the MSL convention of how to capitalize quantities:
Suggested change
| Note that variables with different quantities may be unit-compatible, in particular Work and Torque. | |
| Note that variables with different quantities may be unit-compatible, in particular work and torque. |
There was a problem hiding this comment.
Maybe formulate as an example?
Suggested change
| Note that variables with different quantities may be unit-compatible, in particular Work and Torque. | |
| Note that variables with different quantities may be unit-compatible, as illustrated by work and torque. |
or
Suggested change
| Note that variables with different quantities may be unit-compatible, in particular Work and Torque. | |
| Note that variables with different quantities may be unit-compatible, and as seen in the example of work and torque, the typical choice of units may even be identical (newton-meter). |
There was a problem hiding this comment.
I will take the first one, as work doesn't normally have unit newton-meter, but joule that I would more say is compatible with newton-meter and adding all of that will be too long.
I haven't heard of any other similar issues, so I think it is more the example than an example - that's why "in particular" makes the most sense to me.
There was a problem hiding this comment.
Heard about angles and all dimensionless quantities? :) Then there are also all the quantities building upon work/torque and angle/dimensionless…
henrikt-ma
requested changes
Jan 7, 2025
Co-authored-by: Henrik Tidefelt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on comment in #3626