-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[material-ui][LinearProgress] Deprecate composed classes #44933
Open
headironc
wants to merge
19
commits into
mui:master
Choose a base branch
from
headironc:deprecate-composed-classes
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+578
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ration instructions
…ormation details" This reverts commit 5617d37.
DiegoAndai
reviewed
Jan 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this @headironc!
A couple of this:
- The
MuiLinearProgress-bar1
andMuiLinearProgress-bar2
classes don't exist, we need to add them. When you add them, may I also ask you to add tests to check they're correctly applied? You can use this PR as a guide: https://github.com/mui/material-ui/pull/42281/files - May I also ask you to prepare a sandbox (You can use this one which uses this PR builds) testing that the deprecated classes are correctly replaced by the suggested compositions? For example:
In the sandbox, have two linear progress components, one with:
<LinearProgress
sx={[`&.${linearProgressClasses.bar1Buffer}`]: {
backgroundColor: 'red',
}
/>
and another with:
<Drawer
sx={[`&.${linearProgressClasses.buffer} > .${linearProgressClasses.bar1}`]: {
backgroundColor: 'red',
}
/>
And the result should be the same.
No need to do it with all the combinations, these should be enough:
bar1Buffer
bar1Determinate
bar1Indeterminate
bar2Buffer
barColorPrimary
dashedColorPrimary
packages/mui-codemod/src/deprecations/linear-progress-classes/postcss-plugin.js
Outdated
Show resolved
Hide resolved
30 tasks
@DiegoAndai Okay, I'll finish it. |
…postcss-plugin.js Co-authored-by: Diego Andai <[email protected]> Signed-off-by: headiron <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of 41282