resharding: cold storage #580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staffik
requested review from
wacban and
Trisfald
and removed request for
a team
wacban
approved these changes
Dec 13, 2024
|
|
||
| This mapping strategy enables efficient shard management during resharding events, | ||
| supporting smooth transitions without altering storage structures directly. | ||
|
|
||
| #### Integration with cold storage (archival nodes) |
neps/nep-0568.md
Outdated
| #### Integration with cold storage (archival nodes) | ||
| Cold storage uses the same mapping strategy to manage shard state during resharding: | ||
| * When state data is migrated from hot to cold storage, it retains the parent shard’s `ShardUId` prefix, ensuring consistency with the mapping strategy. | ||
| * While copying data for the final block of the epoch where resharding occured, the `DBCol::StateShardUIdMapping` column is copied into cold storage. This ensures that mappings are updated alongside the shard state data. |
There was a problem hiding this comment.
The word "final" is a bit ambiguous here, can you reword this?
| * While copying data for the final block of the epoch where resharding occured, the `DBCol::StateShardUIdMapping` column is copied into cold storage. This ensures that mappings are updated alongside the shard state data. | ||
| * These mappings are permanent in cold storage, aligning with its role in preserving historical state. | ||
|
|
||
| This approach minimizes complexity while maintaining consistency across hot and cold storage. |
There was a problem hiding this comment.
Can you also mention that the mapping in cold storage is permanent?
There was a problem hiding this comment.
In line 164 there is "These mappings are permanent in cold storage".
wacban
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.