chore: update rocksdb dependency to 0.22 #12672
Open
+30
−55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating rocksdb to 0.22 allows us to remove the run-time CStr → str
conversion when collecting statistics.
rocksdb is at 0.23 however I got dependency resolution failure when
trying to update to that version (included below). Since 0.22 is
enough to resolve one of my TODOs, my job here is done. ;)
error: failed to select a version for `tikv-jemalloc-sys`.
... required by package `tikv-jemallocator v0.5.4`
... which satisfies dependency `tikv-jemallocator = "^0.5.0"` of package `neard v0.0.0 (…)`
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #12672 +/- ##
==========================================
- Coverage 70.51% 70.50% -0.01%
==========================================
Files 845 845
Lines 172258 172251 -7
Branches 172258 172251 -7
==========================================
- Hits 121461 121449 -12
- Misses 45703 45704 +1
- Partials 5094 5098 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
saketh-are
approved these changes
Jan 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating rocksdb to 0.22 allows us to remove the run-time CStr → str conversion when collecting statistics.
rocksdb is at 0.23 however I got dependency resolution failure when trying to update to that version (included below). Since 0.22 is enough to resolve one of my TODOs, my job here is done. ;)