Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ImageLoader] Simplify getSize implementation, call failure callback when decoding fails #2750

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[ImageLoader] Simplify getSize implementation, call failure callback when decoding fails #2750

wants to merge 1 commit into from

Conversation

lkinasiewicz
Copy link

Fixes #2749.

  1. Simplified getSize implementation, so that there is no possibility for infinite timers.
  2. Added handling of decoding failure.
  3. Added unit tests for getSize.

@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Dec 30, 2024 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 04e3092:

Sandbox Source
react-native-web-examples Configuration

TeaFather
TeaFather approved these changes Dec 30, 2024
View reviewed changes
Copy link

@TeaFather TeaFather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like it was over complicated before

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TeaFather TeaFather TeaFather approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ImageLoader.getSize can lead to an infinite interval loop
2 participants
@lkinasiewicz @TeaFather