Skip to content

Commit

Permalink
docker: include vanilla debian postgres client (#10269)
Browse files Browse the repository at this point in the history
## Problem

We are chasing down segfaults in the storage controller
neondatabase/cloud#21010

This is for use by the storage controller, which links dynamically with
`libpq`. We currently use the neon-built libpq, but this may be unsafe
for use from multi-threaded programs like the controller, as it uses a
statically linked openssl

Precursor to #10258

## Summary of changes

- Include `postgresql-15` in container builds.

The reason for using version 15 is simply because that is what's
available in Debian 12 without adding any extra repositories, and we
don't have any special need for latest version in our libpq usage.
  • Loading branch information
jcsp authored Jan 3, 2025
1 parent a77e87a commit 4b2f568
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,8 @@ RUN set -e \
libreadline-dev \
libseccomp-dev \
ca-certificates \
# System postgres for use with client libraries (e.g. in storage controller)
postgresql-15 \
&& rm -rf /var/lib/apt/lists/* /tmp/* /var/tmp/* \
&& useradd -d /data neon \
&& chown -R neon:neon /data
Expand Down

1 comment on commit 4b2f568

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

7377 tests run: 7013 passed, 1 failed, 363 skipped (full report)


Failures on Postgres 16

  • test_storage_controller_many_tenants[github-actions-selfhosted]: release-x86-64
# Run all failed tests locally:
scripts/pytest -vv -n $(nproc) -k "test_storage_controller_many_tenants[release-pg16-github-actions-selfhosted]"
Flaky tests (1)

Postgres 17

Code coverage* (full report)

  • functions: 31.2% (8410 of 26948 functions)
  • lines: 48.0% (66775 of 139204 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
4b2f568 at 2025-01-03T18:19:28.581Z :recycle:

Please sign in to comment.